[DevTools] Move link click and context menu handling to Linkifier.

third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 113 matching lines @@
         return;
 
       Common.Revealer.reveal(this);
     }
     a.addEventListener('click', clickHandler.bind(revealable), false);
     return a;
   }
 
   /**
    * @param {!Element} anchor
-   * @return {?Workspace.UILocation} uiLocation
-   */
-  static uiLocationByAnchor(anchor) {
-    return anchor[Components.Linkifier._uiLocationSymbol];
-  }
-
-  /**
-   * @param {!Element} anchor
    * @param {!Workspace.UILocation} uiLocation
    */
   static _bindUILocation(anchor, uiLocation) {
     anchor[Components.Linkifier._uiLocationSymbol] = uiLocation;
     if (!uiLocation)
       return;
     var uiSourceCode = uiLocation.uiSourceCode;
     var sourceCodeAnchors = uiSourceCode[Components.Linkifier._sourceCodeAnchors];
     if (!sourceCodeAnchors) {
       sourceCodeAnchors = new Set();
@@ skipping 299 matching lines @@
     if (!url) {
       var element = createElementWithClass('span', className);
       element.textContent = text || Common.UIString('(unknown)');
       return element;
     }
 
     var linkText = text || Bindings.displayNameForURL(url);
     if (typeof lineNumber === 'number' && !text)
       linkText += ':' + (lineNumber + 1);
 
-    var anchor = createElementWithClass('a', className);
+    var link = createElementWithClass('a', className);
     if (!url.trim().toLowerCase().startsWith('javascript:')) {
-      anchor.href = url;
-      anchor.classList.add('webkit-html-resource-link');
+      link.href = url;
+      link.classList.add('webkit-html-resource-link');
+      link[Components.Linkifier._linkSymbol] = true;
+      link.addEventListener('click', Components.Linkifier._handleClick, false);
     }
-    anchor.title = linkText !== url ? url : '';
-    anchor.textContent = linkText.trimMiddle(150);
-    anchor.lineNumber = lineNumber;
-    anchor.columnNumber = columnNumber;
-    return anchor;
+    link.title = linkText !== url ? url : '';
+    link.textContent = linkText.trimMiddle(150);
+    link.lineNumber = lineNumber;
+    link.columnNumber = columnNumber;
+    return link;
+  }
+
+  /**
+   * @param {!Event} event
+   */
+  static _handleClick(event) {
+    var link = /** @type {!Element} */ (event.currentTarget);
+    event.consume(true);
+    if (link.preventFollow || UI.isBeingEdited(/** @type {!Node} */ (event.target)))
+      return;
+    if (Components.openAnchorLocationRegistry.dispatch({url: link.href, lineNumber: link.lineNumber}))
+      return;
+    var actions = Components.Linkifier._linkActions(link);
+    if (actions.length)
+      actions[0].handler();

[lushnikov, 2016/11/18 23:43:35]

nit: consider actions[0].handler.call(null) to avoid leaking action

[dgozman, 2016/11/19 02:09:47]

Done.

+  }
+
+  /**
+   * @param {?Element} link
+   * @return {?Array<{title: string, handler: function()}>}

[lushnikov, 2016/11/18 23:43:35]

you probably want to return !Array here - otherwise the actions.length will
through

[dgozman, 2016/11/19 02:09:47]

Nice one! Done.

+   */
+  static _linkActions(link) {
+    var url = null;
+    var uiLocation = null;
+    var isLiveLink = false;
+    if (link && link[Components.Linkifier._uiLocationSymbol]) {
+      uiLocation = /** @type {!Workspace.UILocation} */ (link[Components.Linkifier._uiLocationSymbol]);
+      url = uiLocation.uiSourceCode.contentURL();
+      isLiveLink = true;
+    } else if (link && link.href) {
+      url = link.href;
+      var uiSourceCode = Workspace.workspace.uiSourceCodeForURL(url);
+      uiLocation = uiSourceCode ? uiSourceCode.uiLocation(link.lineNumber || 0, link.columnNumber || 0) : null;
+      isLiveLink = false;
+    } else {
+      return null;
+    }
+
+    var result = [];
+    if (uiLocation)
+      result.push({title: Common.UIString('Open'), handler: () => Common.Revealer.reveal(uiLocation)});
+
+    var resource = Bindings.resourceForURL(url);
+    if (resource) {
+      result.push({
+        title: Common.UIString.capitalize('Open ^link in Application ^panel'),
+        handler: () => Common.Revealer.reveal(resource)
+      });
+    }
+
+    var request = SDK.NetworkLog.requestForURL(url);
+    if (request) {
+      result.push({
+        title: Common.UIString.capitalize('Open ^request in Network ^panel'),
+        handler: () => Common.Revealer.reveal(request)
+      });
+    }
+
+    if (resource || !isLiveLink) {
+      result.push({title: UI.openLinkExternallyLabel(), handler: () => InspectorFrontendHost.openInNewTab(url)});
+      result.push({title: UI.copyLinkAddressLabel(), handler: () => InspectorFrontendHost.copyText(url)});
+    }
+
+    return result;
   }
 };
 
 /** @type {!Set<!Components.Linkifier>} */
 Components.Linkifier._instances = new Set();
 /** @type {?Components.LinkDecorator} */
 Components.Linkifier._decorator = null;
 
 Components.Linkifier._iconSymbol = Symbol('Linkifier.iconSymbol');
 Components.Linkifier._enableDecoratorSymbol = Symbol('Linkifier.enableIconsSymbol');
 Components.Linkifier._sourceCodeAnchors = Symbol('Linkifier.anchors');
 Components.Linkifier._uiLocationSymbol = Symbol('uiLocation');
 Components.Linkifier._fallbackAnchorSymbol = Symbol('fallbackAnchor');
 Components.Linkifier._liveLocationSymbol = Symbol('liveLocation');
+Components.Linkifier._linkSymbol = Symbol('Linkifier.link');
 
 /**
  * The maximum number of characters to display in a URL.
  * @const
  * @type {number}
  */
 Components.Linkifier.MaxLengthForDisplayedURLs = 150;
 
 /**
  * The maximum length before strings are considered too long for finding URLs.
@@ skipping 85 matching lines @@
    * @param {number=} lineNumber
    * @param {number=} columnNumber
    * @return {!Node}
    */
   function linkifier(title, url, lineNumber, columnNumber) {
     return Components.Linkifier.linkifyURL(url, title, undefined, lineNumber, columnNumber);
   }
 
   return Components.linkifyStringAsFragmentWithCustomLinkifier(string, linkifier);
 };
+
+/**
+ * @implements {UI.ContextMenu.Provider}
+ * @unrestricted
+ */
+Components.Linkifier.LinkContextMenuProvider = class {
+  /**
+   * @override
+   * @param {!Event} event
+   * @param {!UI.ContextMenu} contextMenu
+   * @param {!Object} target
+   */
+  appendApplicableItems(event, contextMenu, target) {
+    var targetNode = /** @type {!Node} */ (target);
+    while (targetNode && !targetNode[Components.Linkifier._linkSymbol] &&
+           !targetNode[Components.Linkifier._uiLocationSymbol])
+      targetNode = targetNode.parentNodeOrShadowHost();
+    var link = /** @type {?Element} */ (targetNode);
+    var actions = Components.Linkifier._linkActions(link);
+    if (!actions)
+      return;
+    for (var action of actions)
+      contextMenu.appendItem(action.title, action.handler);
+  }
+};