Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2510193002: Move use_xkbcommon from build to ui/base (Closed)

Created:
4 years, 1 month ago by brettw
Modified:
4 years, 1 month ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, tdresser+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move use_xkbcommon from build to ui/base Converts the ad-hoc defines to use the ui_features buildflag header which should prevent errors. Committed: https://crrev.com/309db1affe0f29366af03a3390f7f3ad56d197b6 Cr-Commit-Position: refs/heads/master@{#433247}

Patch Set 1 #

Patch Set 2 : Typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -28 lines) Patch
M build/config/ui.gni View 1 chunk +0 lines, -3 lines 0 comments Download
M components/exo/wayland/BUILD.gn View 4 chunks +4 lines, -3 lines 0 comments Download
M components/exo/wayland/server.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M ui/base/ui_features.gni View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/events/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/keycodes/BUILD.gn View 1 1 chunk +1 line, -4 lines 0 comments Download
M ui/events/keycodes/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/keycodes/xkb_keysym.h View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/events/ozone/BUILD.gn View 3 chunks +1 line, -8 lines 0 comments Download
M ui/ozone/platform/drm/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/drm/ozone_platform_gbm.cc View 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
brettw
4 years, 1 month ago (2016-11-17 21:13:47 UTC) #2
brettw
Typo
4 years, 1 month ago (2016-11-17 21:51:00 UTC) #7
sadrul
lgtm
4 years, 1 month ago (2016-11-18 01:19:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510193002/20001
4 years, 1 month ago (2016-11-18 18:26:59 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 18:39:47 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 18:43:41 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/309db1affe0f29366af03a3390f7f3ad56d197b6
Cr-Commit-Position: refs/heads/master@{#433247}

Powered by Google App Engine
This is Rietveld 408576698