Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2510163002: Update the prebuilt data file (Closed)

Created:
4 years, 1 month ago by jungshik at Google
Modified:
4 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
icu
Visibility:
Public.

Description

Update the prebuilt data file Update IANA timezone db to 2016i from 2016h See http://mm.icann.org/pipermail/tz-announce/2016-November/000043.html for what's changed. BUG=473288 TBR=mark@chromium.org TEST=Try the following in d8 or Chrome's JS console: > (new Date("11/07/2016 12:00Z")).toLocaleString("en", {timeZone: "Pacific/Tongatapu"}) "11/8/2016, 2:00:00 AM" > (new Date("11/05/2016 12:00Z")).toLocaleString("en", {timeZone: "Pacific/Tongatapu"}) "11/6/2016, 1:00:00 AM" Committed: https://chromium.googlesource.com/chromium/deps/icu/+/4ea7536b6c393cd8339ec24a74bcaf12397f0909

Patch Set 1 #

Patch Set 2 : wd4333 comment added back #

Patch Set 3 : rebased: drop comment for wd4333 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+972 lines, -945 lines) Patch
M android/icudtl.dat View Binary file 0 comments Download
M common/icudtb.dat View Binary file 0 comments Download
M common/icudtl.dat View Binary file 0 comments Download
M source/data/misc/metaZones.txt View 2 chunks +12 lines, -0 lines 0 comments Download
M source/data/misc/timezoneTypes.txt View 1 chunk +1 line, -0 lines 0 comments Download
M source/data/misc/windowsZones.txt View 1 chunk +1 line, -0 lines 0 comments Download
M source/data/misc/zoneinfo64.txt View 120 chunks +958 lines, -945 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
jungshik at Google
Committed patchset #3 (id:40001) manually as 4ea7536b6c393cd8339ec24a74bcaf12397f0909 (presubmit successful).
4 years, 1 month ago (2016-11-17 19:52:46 UTC) #6
Mark Mentovai
4 years, 1 month ago (2016-11-17 19:55:10 UTC) #7
Message was sent while issue was closed.
Thanks for keeping us current, Jungshik. LGTM.

Powered by Google App Engine
This is Rietveld 408576698