Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2510153002:
Run dEQP ES3 tests on Windows AMD bots. (Closed)
|
Created:
4 years, 1 month ago by Jamie Madill Modified:
4 years ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRun dEQP ES3 tests on Windows AMD bots.
It's important for ANGLE to be able to test both NVIDIA and AMD (our
Windows WebGL 2 conformance targets) standalone with dEQP
for correctness on ANGLE rolls and ANGLE try bots. This change will
add the dEQP-GLES3 tests with ANGLE to the Windows AMD GPU.FYI bots,
and the ANGLE CQ. The Optional tester is not included for now.
BUG=641080
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true
Committed: https://crrev.com/597826c59589969bc904e9287adcf2bc9cdcfccf
Cr-Commit-Position: refs/heads/master@{#437354}
Patch Set 1 #Patch Set 2 : Rebase #
Created: 4 years ago
(Patch set is too large to download)
Messages
Total messages: 30 (16 generated)
Description was changed from ========== Run dEQP ES3 tests to Windows ANGLE bots. It's important for ANGLE to be able to test both NVIDIA and AMD (our support Windows WebGL 2 conformance targets) standalone with dEQP for correctness on ANGLE rolls and ANGLE try bots. This change will add the dEQP-GLES3 tests with ANGLE to the Windows GPU.FYI bots, and the ANGLE CQ. The Optional tester is not included for now. BUG=641080 R=kbr@chromium.org ========== to ========== Run dEQP ES3 tests to Windows ANGLE bots. It's important for ANGLE to be able to test both NVIDIA and AMD (our support Windows WebGL 2 conformance targets) standalone with dEQP for correctness on ANGLE rolls and ANGLE try bots. This change will add the dEQP-GLES3 tests with ANGLE to the Windows GPU.FYI bots, and the ANGLE CQ. The Optional tester is not included for now. BUG=641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
PTAL Ken.
Description was changed from ========== Run dEQP ES3 tests to Windows ANGLE bots. It's important for ANGLE to be able to test both NVIDIA and AMD (our support Windows WebGL 2 conformance targets) standalone with dEQP for correctness on ANGLE rolls and ANGLE try bots. This change will add the dEQP-GLES3 tests with ANGLE to the Windows GPU.FYI bots, and the ANGLE CQ. The Optional tester is not included for now. BUG=641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Run dEQP ES3 tests to Windows AMD bots. It's important for ANGLE to be able to test both NVIDIA and AMD (our support Windows WebGL 2 conformance targets) standalone with dEQP for correctness on ANGLE rolls and ANGLE try bots. This change will add the dEQP-GLES3 tests with ANGLE to the Windows AMD GPU.FYI bots, and the ANGLE CQ. The Optional tester is not included for now. BUG=641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Sorry for the delay reviewing. LGTM I updated the CL description -- it seemed a bit confused.
Description was changed from ========== Run dEQP ES3 tests to Windows AMD bots. It's important for ANGLE to be able to test both NVIDIA and AMD (our support Windows WebGL 2 conformance targets) standalone with dEQP for correctness on ANGLE rolls and ANGLE try bots. This change will add the dEQP-GLES3 tests with ANGLE to the Windows AMD GPU.FYI bots, and the ANGLE CQ. The Optional tester is not included for now. BUG=641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Run dEQP ES3 tests to Windows AMD bots. It's important for ANGLE to be able to test both NVIDIA and AMD (our Windows WebGL 2 conformance targets) standalone with dEQP for correctness on ANGLE rolls and ANGLE try bots. This change will add the dEQP-GLES3 tests with ANGLE to the Windows AMD GPU.FYI bots, and the ANGLE CQ. The Optional tester is not included for now. BUG=641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
The CQ bit was checked by jmadill@chromium.org
Description was changed from ========== Run dEQP ES3 tests to Windows AMD bots. It's important for ANGLE to be able to test both NVIDIA and AMD (our Windows WebGL 2 conformance targets) standalone with dEQP for correctness on ANGLE rolls and ANGLE try bots. This change will add the dEQP-GLES3 tests with ANGLE to the Windows AMD GPU.FYI bots, and the ANGLE CQ. The Optional tester is not included for now. BUG=641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Run dEQP ES3 tests on Windows AMD bots. It's important for ANGLE to be able to test both NVIDIA and AMD (our Windows WebGL 2 conformance targets) standalone with dEQP for correctness on ANGLE rolls and ANGLE try bots. This change will add the dEQP-GLES3 tests with ANGLE to the Windows AMD GPU.FYI bots, and the ANGLE CQ. The Optional tester is not included for now. BUG=641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
On 2016/11/22 03:32:41, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...) Looks legit - some of the newly enabled tests failing on AMD GPUs.
On 2016/11/22 21:45:54, Ken Russell wrote: > On 2016/11/22 03:32:41, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...) > > Looks legit - some of the newly enabled tests failing on AMD GPUs. Yup, I added suppressions for those in ANGLE, but I think I want to investigate why these tests are running on AMD only.
The CQ bit was checked by jmadill@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org Link to the patchset: https://codereview.chromium.org/2510153002/#ps20001 (title: "Rebase")
The CQ bit was unchecked by jmadill@chromium.org
The CQ bit was checked by jmadill@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Run dEQP ES3 tests on Windows AMD bots. It's important for ANGLE to be able to test both NVIDIA and AMD (our Windows WebGL 2 conformance targets) standalone with dEQP for correctness on ANGLE rolls and ANGLE try bots. This change will add the dEQP-GLES3 tests with ANGLE to the Windows AMD GPU.FYI bots, and the ANGLE CQ. The Optional tester is not included for now. BUG=641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Run dEQP ES3 tests on Windows AMD bots. It's important for ANGLE to be able to test both NVIDIA and AMD (our Windows WebGL 2 conformance targets) standalone with dEQP for correctness on ANGLE rolls and ANGLE try bots. This change will add the dEQP-GLES3 tests with ANGLE to the Windows AMD GPU.FYI bots, and the ANGLE CQ. The Optional tester is not included for now. BUG=641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel NOTRY=true ==========
landing NOTRY, there's a failure on the Android bots likely because of http://crbug.com/672382
The CQ bit was unchecked by jmadill@chromium.org
The CQ bit was checked by jmadill@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481232648032470,
"parent_rev": "e80330e0990b3ecc4e01ee6511cfa99a293ebed0", "commit_rev":
"1a7252097b2524a3638d225e9df6ebf6abb3ed18"}
Message was sent while issue was closed.
Description was changed from ========== Run dEQP ES3 tests on Windows AMD bots. It's important for ANGLE to be able to test both NVIDIA and AMD (our Windows WebGL 2 conformance targets) standalone with dEQP for correctness on ANGLE rolls and ANGLE try bots. This change will add the dEQP-GLES3 tests with ANGLE to the Windows AMD GPU.FYI bots, and the ANGLE CQ. The Optional tester is not included for now. BUG=641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel NOTRY=true ========== to ========== Run dEQP ES3 tests on Windows AMD bots. It's important for ANGLE to be able to test both NVIDIA and AMD (our Windows WebGL 2 conformance targets) standalone with dEQP for correctness on ANGLE rolls and ANGLE try bots. This change will add the dEQP-GLES3 tests with ANGLE to the Windows AMD GPU.FYI bots, and the ANGLE CQ. The Optional tester is not included for now. BUG=641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Run dEQP ES3 tests on Windows AMD bots. It's important for ANGLE to be able to test both NVIDIA and AMD (our Windows WebGL 2 conformance targets) standalone with dEQP for correctness on ANGLE rolls and ANGLE try bots. This change will add the dEQP-GLES3 tests with ANGLE to the Windows AMD GPU.FYI bots, and the ANGLE CQ. The Optional tester is not included for now. BUG=641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel NOTRY=true ========== to ========== Run dEQP ES3 tests on Windows AMD bots. It's important for ANGLE to be able to test both NVIDIA and AMD (our Windows WebGL 2 conformance targets) standalone with dEQP for correctness on ANGLE rolls and ANGLE try bots. This change will add the dEQP-GLES3 tests with ANGLE to the Windows AMD GPU.FYI bots, and the ANGLE CQ. The Optional tester is not included for now. BUG=641080 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel NOTRY=true Committed: https://crrev.com/597826c59589969bc904e9287adcf2bc9cdcfccf Cr-Commit-Position: refs/heads/master@{#437354} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/597826c59589969bc904e9287adcf2bc9cdcfccf Cr-Commit-Position: refs/heads/master@{#437354}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2567793002/ by jmadill@chromium.org. The reason for reverting is: Looks like the generated json didn't get updated properly..
Message was sent while issue was closed.
On 2016/12/09 20:17:04, Jamie Madill wrote: > A revert of this CL (patchset #2 id:20001) has been created in > https://codereview.chromium.org/2567793002/ by mailto:jmadill@chromium.org. > > The reason for reverting is: Looks like the generated json didn't get updated > properly.. Sorry, I should have noticed that chromium.gpu.fyi.json wasn't updated in this CL. In the future you can land these JSON changes NOTRY=true to get them in faster, especially if a lot of people are hammering on them at the same time. (Coordination's needed in that case. There are frequent incorrectly-applied patches here because the files are so repetitive.)
Message was sent while issue was closed.
On 2016/12/09 21:35:58, Ken Russell wrote: > On 2016/12/09 20:17:04, Jamie Madill wrote: > > A revert of this CL (patchset #2 id:20001) has been created in > > https://codereview.chromium.org/2567793002/ by mailto:jmadill@chromium.org. > > > > The reason for reverting is: Looks like the generated json didn't get updated > > properly.. > > Sorry, I should have noticed that chromium.gpu.fyi.json wasn't updated in this > CL. > > In the future you can land these JSON changes NOTRY=true to get them in faster, > especially if a lot of people are hammering on them at the same time. > (Coordination's needed in that case. There are frequent incorrectly-applied > patches here because the files are so repetitive.) Thanks, will do. It was annoying, when I uploaded the diff, it said 'not uploading <json>, file too large'. I saw this, but didn't understand it just for some reason skipped uploading the json even though it was correctly generated. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
