Chromium Code Reviews
Help | Chromium Project | Sign in
(1185)

Issue 251014: * Fix memory leaks caused by thread local data being lost.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by Erik Corry
Modified:
2 years, 11 months ago
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

* Fix memory leaks caused by thread local data being lost.
* Rename some instance variables and accessors to fit code style.
* Don't overwrite existing thread ID.

Committed: http://code.google.com/p/v8/source/detail?r=2977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -53 lines) Lint Patch
M src/api.h View 4 chunks +44 lines, -31 lines 0 comments 0 errors Download
M src/api.cc View 4 chunks +11 lines, -6 lines 0 comments 0 errors Download
M src/bootstrapper.h View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M src/bootstrapper.cc View 1 chunk +6 lines, -0 lines 0 comments 0 errors Download
M src/debug.h View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M src/execution.h View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M src/execution.cc View 1 chunk +4 lines, -0 lines 0 comments 0 errors Download
M src/handles.cc View 3 chunks +5 lines, -5 lines 0 comments 0 errors Download
M src/regexp-stack.h View 2 chunks +2 lines, -0 lines 0 comments 0 errors Download
M src/regexp-stack.cc View 1 chunk +8 lines, -0 lines 0 comments 0 errors Download
M src/serialize.cc View 2 chunks +2 lines, -2 lines 0 comments 0 errors Download
M src/top.h View 2 chunks +7 lines, -0 lines 0 comments 0 errors Download
M src/top.cc View 1 chunk +2 lines, -1 line 0 comments 0 errors Download
M src/v8threads.h View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M src/v8threads.cc View 2 chunks +15 lines, -1 line 0 comments 0 errors Download
M test/cctest/test-log.cc View 1 chunk +0 lines, -7 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 2
Erik Corry
4 years, 6 months ago #1
Søren Thygesen Gjesse
4 years, 6 months ago #2
LGTM,

however I find the use of Initialize function setting spare_ to NULL in the
thread archiving a bit confusing. How about remove the call to Initialize from
the HandleScopeImplementer constructor, and just initialize all members in the
constructor initializer list, and then change the name from Initialize to
"ReserAfterArchive" - or something like that.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6