Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2510133003: [ObjC ARC] Converts ios/chrome/browser/geolocation:test_support to ARC.Automatically generated AR… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
3 years, 6 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, sdefresne+watch_chromium.org, pkl (ping after 24h if needed), mac-reviews_chromium.org, mlamouri+watch-geolocation_chromium.org, Michael van Ouwerkerk
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/geolocation:test_support to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/9dc011f657a3d5fec551b2f5512f8d62a2a01458 Cr-Commit-Position: refs/heads/master@{#436283}

Patch Set 1 #

Total comments: 4

Patch Set 2 : git cl hel[ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -19 lines) Patch
M ios/chrome/browser/geolocation/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/geolocation/test_location_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/geolocation/test_location_manager.mm View 1 2 chunks +6 lines, -18 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
stkhapugin
PTAL. Passes downstream tests.
4 years ago (2016-11-25 09:50:58 UTC) #6
sdefresne
lgtm https://codereview.chromium.org/2510133003/diff/1/ios/chrome/browser/geolocation/test_location_manager.mm File ios/chrome/browser/geolocation/test_location_manager.mm (right): https://codereview.chromium.org/2510133003/diff/1/ios/chrome/browser/geolocation/test_location_manager.mm#newcode14 ios/chrome/browser/geolocation/test_location_manager.mm:14: CLAuthorizationStatus _authorizationStatus; nit: remove https://codereview.chromium.org/2510133003/diff/1/ios/chrome/browser/geolocation/test_location_manager.mm#newcode16 ios/chrome/browser/geolocation/test_location_manager.mm:16: BOOL _locationServicesEnabled; ...
4 years ago (2016-11-25 10:13:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510133003/20001
4 years ago (2016-12-05 13:10:29 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 14:05:11 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-05 14:07:23 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9dc011f657a3d5fec551b2f5512f8d62a2a01458
Cr-Commit-Position: refs/heads/master@{#436283}

Powered by Google App Engine
This is Rietveld 408576698