Add getCoalescedEvents API to PointerEvent

Add getCoalescedEvents API to PointerEvent

Adding getCoalescedEvents API to the idl file
of PointerEventInit and getter method to
PointerEvent idl.
Also add the plumbing and creation in EventHandler
layer and PointerEventManager.

BUG=665937
Committed: https://crrev.com/92109dbbe9d1a2f422aff101e69ab123a70c56d1
Cr-Commit-Position: refs/heads/master@{#434849}

[Navid Zolghadr, 2016-11-17 17:49:54]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 17:50:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 18:33:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 18:33:17]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Navid Zolghadr, 2016-11-17 19:13:59]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 19:14:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-11-17 19:47:21]

nzolghadr@chromium.org changed reviewers:
+ dtapuska@chromium.org, mustaq@chromium.org

[Navid Zolghadr, 2016-11-17 19:47:21]

This is the first part of adding getCoalescedEvents. Here is the full review in
case you'd like to take a peek:
https://codereview.chromium.org/2479123003/

Note that this review doesn't have any new class containing both the event and
its coalesced events. From the WebInputEvent to PlatformEvents I just used a
vector instead of adding new Platform class. Let me know what you think.

Also there seems to be a compile error on android for std::vector expecting two
parameters. I'm not sure why I'm getting this error as other places also just
passed the type of the vector and not the allocator. Any idea why and how to
solve it?

[commit-bot: I haz the power, 2016-11-17 19:54:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 19:54:51]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[dtapuska, 2016-11-21 15:51:56]

https://codereview.chromium.org/2510133002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/PointerEventFactory.cpp (right):

https://codereview.chromium.org/2510133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactory.cpp:260:
pointerEventInit.setCoalescedEvents(coalescedPointerEvents);
can we DCHECK that coalescedPointerEvents is size 0; if mouseEventName !=
mousemove?

https://codereview.chromium.org/2510133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactory.cpp:306:
pointerEventInit.setCoalescedEvents(coalescedPointerEvents);
can we DCHECK that coalescedPoitnerEvents is size 0, if pointState isn't a
TouchMove?

https://codereview.chromium.org/2510133002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebInputEventConversion.cpp (right):

https://codereview.chromium.org/2510133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebInputEventConversion.cpp:836:
result.append(PlatformMouseEventBuilder(
Should we check the type on the WebInputEvent before the cast?

https://codereview.chromium.org/2510133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebInputEventConversion.cpp:847:
result.append(PlatformTouchEventBuilder(
ditto

[Navid Zolghadr, 2016-11-21 19:34:44]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[Navid Zolghadr, 2016-11-21 19:35:12]

ptal.

https://codereview.chromium.org/2510133002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/PointerEventFactory.cpp (right):

https://codereview.chromium.org/2510133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactory.cpp:260:
pointerEventInit.setCoalescedEvents(coalescedPointerEvents);
On 2016/11/21 15:51:56, dtapuska wrote:
> can we DCHECK that coalescedPointerEvents is size 0; if mouseEventName !=
> mousemove?

Done.

https://codereview.chromium.org/2510133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactory.cpp:306:
pointerEventInit.setCoalescedEvents(coalescedPointerEvents);
On 2016/11/21 15:51:56, dtapuska wrote:
> can we DCHECK that coalescedPoitnerEvents is size 0, if pointState isn't a
> TouchMove?

Done.

https://codereview.chromium.org/2510133002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebInputEventConversion.cpp (right):

https://codereview.chromium.org/2510133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebInputEventConversion.cpp:836:
result.append(PlatformMouseEventBuilder(
On 2016/11/21 15:51:56, dtapuska wrote:
> Should we check the type on the WebInputEvent before the cast?

I don't think there is anything this function can do at this point since the
caller decides which function to call based on the type of the WebInputEvent. Is
that enough to have a DCHECK or do you want me to skip adding the event if it is
not mouse event for example here?

[commit-bot: I haz the power, 2016-11-21 19:35:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mustaq, 2016-11-21 20:53:54]

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/PointerEventFactory.cpp (right):

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactory.cpp:103: void
updateTouchPointPointerEventInit(const PlatformTouchPoint& touchPoint,
You meant "updateTouchPointerEventInit" instead?

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactory.cpp:117: FloatSize
pointRadius = touchPoint.radius().scaledBy(scaleFactor);
Radius, width & height should be outside the |if| block.

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactory.cpp:147: // Set up
initial values for coordinates.
Please get rid of this old comment line, the values doesn't change as the
comment seems to suggest.

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactory.cpp:260:
coalescedPointerEvents.append(
Add a DCHECK here for matching (with the container event) id, isPrimary and
pointerType.

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactory.cpp:307:
coalescedPointerEvents.append(
Ditto.

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp (right):

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp:111: size_t
coalescedEventCount) {
May be pass id[], isPrimary[] and pointerType[] and test that it throws when
they are not identical?

Alternatively (perhaps better?): add another block at the end of this method for
the EXPECT_THROW case?

Same for createAndCheckMouseEvent below.

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp:126:
EXPECT_EQ(isPrimary, pointerEvent->getCoalescedEvents()[i]->isPrimary());
Also check pointerType. Same for the container ("dispatched") event.

Same for createAndCheckMouseEvent below.

[Navid Zolghadr, 2016-11-21 21:31:21]

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/PointerEventFactory.cpp (right):

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactory.cpp:103: void
updateTouchPointPointerEventInit(const PlatformTouchPoint& touchPoint,
On 2016/11/21 20:53:53, mustaq wrote:
> You meant "updateTouchPointerEventInit" instead?

Done.

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactory.cpp:117: FloatSize
pointRadius = touchPoint.radius().scaledBy(scaleFactor);
On 2016/11/21 20:53:53, mustaq wrote:
> Radius, width & height should be outside the |if| block.

But scaleFactor comes from the targetFrame. What should I do in that case?

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactory.cpp:147: // Set up
initial values for coordinates.
On 2016/11/21 20:53:53, mustaq wrote:
> Please get rid of this old comment line, the values doesn't change as the
> comment seems to suggest.

Done.

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactory.cpp:260:
coalescedPointerEvents.append(
On 2016/11/21 20:53:53, mustaq wrote:
> Add a DCHECK here for matching (with the container event) id, isPrimary and
> pointerType.

I'm not sure what the DCHECK would achieve here. We don't have the container
event here yet. We only have its pointerEventInit. Beside adding that DCHECK
fills like adding a dcheck for the constructor of PointerEvent to make sure it
copies stuff from the init. Right?
Do you want me to add a DCHECK after updateMousePointerEventInit to make sure
both the modified init and the container init have the same id, isPrimary, and
pointerType?

Alternatively, I can add a DCHECK for rawId and pointerType of the given input
events o be as all the coalesced ones. However, either way even if the DCHECK
fails this function doesn't reflect the id and type of the original coalesced
events here as those will be already there in the init from the container event.

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp (right):

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp:111: size_t
coalescedEventCount) {
On 2016/11/21 20:53:53, mustaq wrote:
> May be pass id[], isPrimary[] and pointerType[] and test that it throws when
> they are not identical?
> 
> Alternatively (perhaps better?): add another block at the end of this method
for
> the EXPECT_THROW case?
> 
> Same for createAndCheckMouseEvent below.

I'm a little confused here. What throw? The code never throws particularly in
release build event if I add a DCHECK. Beside APIs in PointerEventFactor don't
get isPrimary or id of the pointer event if that is what you meant.

[Navid Zolghadr, 2016-11-21 21:53:00]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 21:53:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 01:12:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 01:12:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mustaq, 2016-11-22 15:31:10]

One more point, about tests:

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/PointerEventFactory.cpp (right):

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactory.cpp:117: FloatSize
pointRadius = touchPoint.radius().scaledBy(scaleFactor);
On 2016/11/21 21:31:21, Navid Zolghadr wrote:
> On 2016/11/21 20:53:53, mustaq wrote:
> > Radius, width & height should be outside the |if| block.
> 
> But scaleFactor comes from the targetFrame. What should I do in that case?

I thought it's a bug because when target frame is null, missing client
coordinates makes sense but missing width/height doesn't. Just realized that
width/height defaults to 1 in PointerEventInit. So it looks good.

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactory.cpp:260:
coalescedPointerEvents.append(
On 2016/11/21 21:31:21, Navid Zolghadr wrote:
> On 2016/11/21 20:53:53, mustaq wrote:
> > Add a DCHECK here for matching (with the container event) id, isPrimary and
> > pointerType.
> 
> I'm not sure what the DCHECK would achieve here. We don't have the container
> event here yet. We only have its pointerEventInit. Beside adding that DCHECK
> fills like adding a dcheck for the constructor of PointerEvent to make sure it
> copies stuff from the init. Right?
> Do you want me to add a DCHECK after updateMousePointerEventInit to make sure
> both the modified init and the container init have the same id, isPrimary, and
> pointerType?
> 
> Alternatively, I can add a DCHECK for rawId and pointerType of the given input
> events o be as all the coalesced ones. However, either way even if the DCHECK
> fails this function doesn't reflect the id and type of the original coalesced
> events here as those will be already there in the init from the container
event.

Right but we still need to enforce the equality of these properties.
PointerEvent constructor looks like a better place, right?

https://codereview.chromium.org/2510133002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right):

https://codereview.chromium.org/2510133002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:35: CoalescedEvents
status=experimental
Let's add a virtual test suite and update at least the test
pointer-event-constructor.html for now. This may sound overkill for this CL but
in the long run we will definitely want to test coalesced pointers through
layouttests.

[Navid Zolghadr, 2016-11-22 15:59:28]

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/PointerEventFactory.cpp (right):

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactory.cpp:260:
coalescedPointerEvents.append(
On 2016/11/22 15:31:10, mustaq wrote:
> On 2016/11/21 21:31:21, Navid Zolghadr wrote:
> > On 2016/11/21 20:53:53, mustaq wrote:
> > > Add a DCHECK here for matching (with the container event) id, isPrimary
and
> > > pointerType.
> > 
> > I'm not sure what the DCHECK would achieve here. We don't have the container
> > event here yet. We only have its pointerEventInit. Beside adding that DCHECK
> > fills like adding a dcheck for the constructor of PointerEvent to make sure
it
> > copies stuff from the init. Right?
> > Do you want me to add a DCHECK after updateMousePointerEventInit to make
sure
> > both the modified init and the container init have the same id, isPrimary,
and
> > pointerType?
> > 
> > Alternatively, I can add a DCHECK for rawId and pointerType of the given
input
> > events o be as all the coalesced ones. However, either way even if the
DCHECK
> > fails this function doesn't reflect the id and type of the original
coalesced
> > events here as those will be already there in the init from the container
> event.
> 
> Right but we still need to enforce the equality of these properties.
> PointerEvent constructor looks like a better place, right?

I don't think that is the case either as that path will get called when js calls
into the constructor directly and they can set anything they want.

https://codereview.chromium.org/2510133002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right):

https://codereview.chromium.org/2510133002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:35: CoalescedEvents
status=experimental
On 2016/11/22 15:31:10, mustaq wrote:
> Let's add a virtual test suite and update at least the test
> pointer-event-constructor.html for now. This may sound overkill for this CL
but
> in the long run we will definitely want to test coalesced pointers through
> layouttests.

Why a virtual test suite? It is in experimental anyway. I can add it to the
current constructor test. Right?

[Navid Zolghadr, 2016-11-22 19:40:23]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 19:40:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-11-22 19:42:16]

ptal.

[mustaq, 2016-11-22 21:07:51]

LGTM % checks for all 3 properties...

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/PointerEventFactory.cpp (right):

https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/PointerEventFactory.cpp:260:
coalescedPointerEvents.append(
On 2016/11/22 15:59:28, Navid Zolghadr wrote:
> On 2016/11/22 15:31:10, mustaq wrote:
> > On 2016/11/21 21:31:21, Navid Zolghadr wrote:
> > > On 2016/11/21 20:53:53, mustaq wrote:
> > > > Add a DCHECK here for matching (with the container event) id, isPrimary
> and
> > > > pointerType.
> > > 
> > > I'm not sure what the DCHECK would achieve here. We don't have the
container
> > > event here yet. We only have its pointerEventInit. Beside adding that
DCHECK
> > > fills like adding a dcheck for the constructor of PointerEvent to make
sure
> it
> > > copies stuff from the init. Right?
> > > Do you want me to add a DCHECK after updateMousePointerEventInit to make
> sure
> > > both the modified init and the container init have the same id, isPrimary,
> and
> > > pointerType?
> > > 
> > > Alternatively, I can add a DCHECK for rawId and pointerType of the given
> input
> > > events o be as all the coalesced ones. However, either way even if the
> DCHECK
> > > fails this function doesn't reflect the id and type of the original
> coalesced
> > > events here as those will be already there in the init from the container
> > event.
> > 
> > Right but we still need to enforce the equality of these properties.
> > PointerEvent constructor looks like a better place, right?
> 
> I don't think that is the case either as that path will get called when js
calls
> into the constructor directly and they can set anything they want.

Instead of the raw data checks you have added, let's check the properties in
inits (coalesced vs container) as I originally meant. We need to catch bad
values in trusted events.

This solution won't test the final event (and don't want another loop before the
|return| just for this) but we already test init->event value propagation in
other places.

Same for the touch-type create() below.

https://codereview.chromium.org/2510133002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right):

https://codereview.chromium.org/2510133002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:35: CoalescedEvents
status=experimental
On 2016/11/22 15:59:28, Navid Zolghadr wrote:
> On 2016/11/22 15:31:10, mustaq wrote:
> > Let's add a virtual test suite and update at least the test
> > pointer-event-constructor.html for now. This may sound overkill for this CL
> but
> > in the long run we will definitely want to test coalesced pointers through
> > layouttests.
> 
> Why a virtual test suite? It is in experimental anyway. I can add it to the
> current constructor test. Right?

Right.

[Navid Zolghadr, 2016-11-22 21:35:19]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 21:35:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 00:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 00:03:44]

Dry run: This issue passed the CQ dry run.

[Navid Zolghadr, 2016-11-23 16:03:44]

On 2016/11/22 21:07:51, mustaq wrote:
> LGTM % checks for all 3 properties...
> 
>
https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/events/PointerEventFactory.cpp (right):
> 
>
https://codereview.chromium.org/2510133002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/events/PointerEventFactory.cpp:260:
> coalescedPointerEvents.append(
> On 2016/11/22 15:59:28, Navid Zolghadr wrote:
> > On 2016/11/22 15:31:10, mustaq wrote:
> > > On 2016/11/21 21:31:21, Navid Zolghadr wrote:
> > > > On 2016/11/21 20:53:53, mustaq wrote:
> > > > > Add a DCHECK here for matching (with the container event) id,
isPrimary
> > and
> > > > > pointerType.
> > > > 
> > > > I'm not sure what the DCHECK would achieve here. We don't have the
> container
> > > > event here yet. We only have its pointerEventInit. Beside adding that
> DCHECK
> > > > fills like adding a dcheck for the constructor of PointerEvent to make
> sure
> > it
> > > > copies stuff from the init. Right?
> > > > Do you want me to add a DCHECK after updateMousePointerEventInit to make
> > sure
> > > > both the modified init and the container init have the same id,
isPrimary,
> > and
> > > > pointerType?
> > > > 
> > > > Alternatively, I can add a DCHECK for rawId and pointerType of the given
> > input
> > > > events o be as all the coalesced ones. However, either way even if the
> > DCHECK
> > > > fails this function doesn't reflect the id and type of the original
> > coalesced
> > > > events here as those will be already there in the init from the
container
> > > event.
> > > 
> > > Right but we still need to enforce the equality of these properties.
> > > PointerEvent constructor looks like a better place, right?
> > 
> > I don't think that is the case either as that path will get called when js
> calls
> > into the constructor directly and they can set anything they want.
> 
> Instead of the raw data checks you have added, let's check the properties in
> inits (coalesced vs container) as I originally meant. We need to catch bad
> values in trusted events.
> 
> This solution won't test the final event (and don't want another loop before
the
> |return| just for this) but we already test init->event value propagation in
> other places.
> 
> Same for the touch-type create() below.

I added the comments for the update*PointerEventInit functions instead as per
our offline discussion.

> 
>
https://codereview.chromium.org/2510133002/diff/60001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right):
> 
>
https://codereview.chromium.org/2510133002/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:35:
CoalescedEvents
> status=experimental
> On 2016/11/22 15:59:28, Navid Zolghadr wrote:
> > On 2016/11/22 15:31:10, mustaq wrote:
> > > Let's add a virtual test suite and update at least the test
> > > pointer-event-constructor.html for now. This may sound overkill for this
CL
> > but
> > > in the long run we will definitely want to test coalesced pointers through
> > > layouttests.
> > 
> > Why a virtual test suite? It is in experimental anyway. I can add it to the
> > current constructor test. Right?
> 
> Right.

[Navid Zolghadr, 2016-11-23 16:05:11]

nzolghadr@chromium.org changed reviewers:
+ bokan@chromium.org

[dtapuska, 2016-11-23 16:57:15]

On 2016/11/23 16:05:11, Navid Zolghadr wrote:

lgtm

[dtapuska, 2016-11-23 16:57:24]

https://codereview.chromium.org/2510133002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/events/PointerEvent.cpp (right):

https://codereview.chromium.org/2510133002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/events/PointerEvent.cpp:39: for (auto
coalescedEvent : initializer.coalescedEvents()) {
don't think you need the braces for the for loop

[bokan, 2016-11-23 16:57:45]

rs lgtm based on Mustaq's review

[Navid Zolghadr, 2016-11-23 17:01:33]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 17:02:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-11-23 17:04:10]

https://codereview.chromium.org/2510133002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/events/PointerEvent.cpp (right):

https://codereview.chromium.org/2510133002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/events/PointerEvent.cpp:39: for (auto
coalescedEvent : initializer.coalescedEvents()) {
On 2016/11/23 16:57:24, dtapuska wrote:
> don't think you need the braces for the for loop

Removed.

[Navid Zolghadr, 2016-11-23 20:23:22]

The CQ bit was unchecked by nzolghadr@chromium.org

[Navid Zolghadr, 2016-11-23 20:25:11]

nzolghadr@chromium.org changed reviewers:
+ rbyers@chromium.org

[Navid Zolghadr, 2016-11-23 20:25:12]

rbyers@chromium.org: Please review changes in 

third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

[Rick Byers, 2016-11-25 15:53:40]

On 2016/11/23 at 20:25:12, nzolghadr wrote:
> rbyers@chromium.org: Please review changes in 
> 
> third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

platform/ LGTM

[Navid Zolghadr, 2016-11-28 15:32:46]

The CQ bit was checked by nzolghadr@chromium.org

[Navid Zolghadr, 2016-11-28 15:32:47]

The patchset sent to the CQ was uploaded after l-g-t-m from mustaq@chromium.org,
dtapuska@chromium.org, bokan@chromium.org
Link to the patchset: https://codereview.chromium.org/2510133002/#ps120001
(title: "Remove extra braces")

[commit-bot: I haz the power, 2016-11-28 15:32:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 16:05:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 16:05:31]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Navid Zolghadr, 2016-11-28 18:18:21]

The CQ bit was checked by nzolghadr@chromium.org

[Navid Zolghadr, 2016-11-28 18:18:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtapuska@chromium.org, mustaq@chromium.org, rbyers@chromium.org,
bokan@chromium.org
Link to the patchset: https://codereview.chromium.org/2510133002/#ps140001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-28 18:19:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 20:28:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 20:28:18]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
no build URL)

[Navid Zolghadr, 2016-11-28 21:41:23]

The CQ bit was checked by nzolghadr@chromium.org

[commit-bot: I haz the power, 2016-11-28 21:43:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 02:55:37]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1480369283823650,
"parent_rev": "67cd660dd85298da6ee6c895cc5de075eb087fb7", "commit_rev":
"4c255f7c8897d50bf5cb48e863817bd0246355fd"}

[commit-bot: I haz the power, 2016-11-29 02:56:08]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-11-29 03:04:11]

Description was changed from

==========
Add getCoalescedEvents API to PointerEvent

Adding getCoalescedEvents API to the idl file
of PointerEventInit and getter method to
PointerEvent idl.
Also add the plumbing and creation in EventHandler
layer and PointerEventManager.

BUG=665937
==========

to

==========
Add getCoalescedEvents API to PointerEvent

Adding getCoalescedEvents API to the idl file
of PointerEventInit and getter method to
PointerEvent idl.
Also add the plumbing and creation in EventHandler
layer and PointerEventManager.

BUG=665937

Committed: https://crrev.com/92109dbbe9d1a2f422aff101e69ab123a70c56d1
Cr-Commit-Position: refs/heads/master@{#434849}
==========

[commit-bot: I haz the power, 2016-11-29 03:04:13]

Patchset 8 (id:??) landed as
https://crrev.com/92109dbbe9d1a2f422aff101e69ab123a70c56d1
Cr-Commit-Position: refs/heads/master@{#434849}