Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 251013003: Allow range to be specified using dates. (Closed)

Created:
6 years, 8 months ago by reveman
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Allow range to be specified using dates. e.g. range={2008-08-25}:{2008-08-26} Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=270306

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M dashboard/svn-log View 1 chunk +4 lines, -1 line 1 comment Download

Messages

Total messages: 9 (0 generated)
reveman
This would be really useful in a chrome extension I'm writing. Wdyt?
6 years, 8 months ago (2014-04-25 21:40:30 UTC) #1
cmp
+mmoss, agable, iannucci who can review
6 years, 8 months ago (2014-04-25 21:43:18 UTC) #2
reveman
https://codereview.chromium.org/251013003/diff/1/dashboard/svn-log File dashboard/svn-log (right): https://codereview.chromium.org/251013003/diff/1/dashboard/svn-log#newcode20 dashboard/svn-log:20: ':{(\d{4}-(1[0-2]|0?[1-9])-(3[01]|[12][0-9]|0?[1-9]))}$', fyi, this is not perfect. ie. it doesn't ...
6 years, 8 months ago (2014-04-25 21:46:28 UTC) #3
agable
Is trunk/tools/perf/dashboard even used anymore? I thought all the perf dashboard code was in google3 ...
6 years, 8 months ago (2014-04-26 18:43:45 UTC) #4
qyearsley
On 2014/04/26 18:43:45, agable wrote: > Is trunk/tools/perf/dashboard even used anymore? I thought all the ...
6 years, 8 months ago (2014-04-27 03:09:52 UTC) #5
qyearsley
By the way, this CL LGTM.
6 years, 7 months ago (2014-05-13 23:48:17 UTC) #6
reveman
The CQ bit was checked by reveman@chromium.org
6 years, 7 months ago (2014-05-14 02:56:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/251013003/1
6 years, 7 months ago (2014-05-14 02:56:42 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-14 02:56:47 UTC) #9
Message was sent while issue was closed.
Change committed as 270306

Powered by Google App Engine
This is Rietveld 408576698