Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2510093005: Revert "Fix tsan failure" (Closed)

Created:
4 years, 1 month ago by siva
Modified:
4 years, 1 month ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Fix tsan failure" This reverts commit 159a5ab3667b95a74d2be06d880bb75d74a895df. This reverts commit aa76de9a8f30755aad2cb6797ae1a0ed6b50da21. BUG= Committed: https://github.com/dart-lang/sdk/commit/66cb033ac11dfc576967025ba4a20e3aefbf41f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -187 lines) Patch
M runtime/observatory/tests/service/get_allocation_samples_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/platform/assert.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/os_thread_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/os_thread_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/os_thread_macos.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/profiler.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/profiler.cc View 9 chunks +103 lines, -89 lines 0 comments Download
M runtime/vm/profiler_test.cc View 37 chunks +13 lines, -89 lines 0 comments Download
M runtime/vm/stack_frame.h View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
TBR=rmacnak
4 years, 1 month ago (2016-11-19 00:44:22 UTC) #2
siva
Committed patchset #1 (id:1) manually as 66cb033ac11dfc576967025ba4a20e3aefbf41f2 (presubmit successful).
4 years, 1 month ago (2016-11-19 00:44:37 UTC) #4
rmacnak
4 years, 1 month ago (2016-11-19 01:04:24 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698