Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2510093004: Test that base page is available in Reader Mode (Closed)

Created:
4 years, 1 month ago by mdjones
Modified:
4 years ago
Reviewers:
wychen
CC:
chromium-reviews, mdjones+watch_chromium.org, donnd+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test that base page is available in Reader Mode If there is no web contents to distill, stop trying to open the Reader Mode panel. BUG=666277 Committed: https://crrev.com/fd24a95763656415b318337cd53875d08931857e Cr-Commit-Position: refs/heads/master@{#434812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java View 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mdjones
ptal
4 years, 1 month ago (2016-11-18 18:09:48 UTC) #2
wychen
lgtm
4 years ago (2016-11-28 22:58:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510093004/1
4 years ago (2016-11-28 23:33:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 01:23:36 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-29 01:29:17 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd24a95763656415b318337cd53875d08931857e
Cr-Commit-Position: refs/heads/master@{#434812}

Powered by Google App Engine
This is Rietveld 408576698