src/inspector/java-script-call-frame.h - Issue 2510093002: [inspector] gracefully handle stack overflows in the inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/inspector/java-script-call-frame.h

Issue 2510093002: [inspector] gracefully handle stack overflows in the inspector. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/inspector/java-script-call-frame.h

diff --git a/src/inspector/java-script-call-frame.h b/src/inspector/java-script-call-frame.h

index 5a4ce19cc20ef646a215647c545201591e1bd2f4..c714cb09b122326feb6c3181048b7fad49c9083b 100644

--- a/src/inspector/java-script-call-frame.h

+++ b/src/inspector/java-script-call-frame.h

@@ -54,7 +54,7 @@ class JavaScriptCallFrame {

int contextId() const;

bool isAtReturn() const;

- v8::Local<v8::Object> details() const;

+ v8::MaybeLocal<v8::Value> details() const;

v8::MaybeLocal<v8::Value> evaluate(v8::Local<v8::Value> expression);

v8::MaybeLocal<v8::Value> restart();