Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2782)

Unified Diff: ash/common/system/chromeos/network/vpn_delegate_unittest.cc

Issue 2510083006: chromeos: Move ownership of ash VPN provider list from chrome into ash (Closed)
Patch Set: Collapse VPNProvider::Key and VPNProvider structs Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/chromeos/network/vpn_delegate_unittest.cc
diff --git a/ash/common/system/chromeos/network/vpn_delegate_unittest.cc b/ash/common/system/chromeos/network/vpn_delegate_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..be032a779b82d816895eaa632b3fb1d333246248
--- /dev/null
+++ b/ash/common/system/chromeos/network/vpn_delegate_unittest.cc
@@ -0,0 +1,62 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/common/system/chromeos/network/vpn_delegate.h"
+
+#include <algorithm>
+#include <vector>
+
+#include "base/macros.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace ash {
+
+namespace {
+
+class TestVpnDelegate : public VPNDelegate {
+ public:
+ TestVpnDelegate() {}
+ ~TestVpnDelegate() override {}
+
+ // VPNDelegate:
+ void ShowAddPage(const std::string& extension_id) override {}
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(TestVpnDelegate);
+};
+
+} // namespace
+
+using VpnDelegateTest = testing::Test;
+
+TEST_F(VpnDelegateTest, BuiltInProvider) {
+ TestVpnDelegate delegate;
+
+ // The VPN list should only contain the built-in provider.
+ ASSERT_EQ(1u, delegate.vpn_providers().size());
+ VPNProvider provider = delegate.vpn_providers()[0];
+ EXPECT_FALSE(provider.third_party);
+ EXPECT_TRUE(provider.extension_id.empty());
+}
+
+TEST_F(VpnDelegateTest, ThirdPartyProviders) {
+ TestVpnDelegate delegate;
+
+ // The VPN list should only contain the built-in provider.
+ EXPECT_EQ(1u, delegate.vpn_providers().size());
+
+ // Add some third party (extension-backed) providers.
+ VPNProvider provider1("extension_id1", "name1");
+ VPNProvider provider2("extension_id2", "name2");
+ std::vector<VPNProvider> third_party_providers = {provider1, provider2};
+ delegate.SetThirdPartyVpnProviders(third_party_providers);
+
+ // List contains the extension-backed providers. Order doesn't matter.
+ std::vector<VPNProvider> providers = delegate.vpn_providers();
+ EXPECT_EQ(3u, providers.size());
+ EXPECT_EQ(1u, std::count(providers.begin(), providers.end(), provider1));
+ EXPECT_EQ(1u, std::count(providers.begin(), providers.end(), provider2));
+}
+
+} // namespace ash

Powered by Google App Engine
This is Rietveld 408576698