WebVR: enable Cardboard button compatibility

WebVR: Fix Cardboard button processing

In native WebVR mode on a Cardboard style headset with capacitive touch
button, need to forward these touch events to the Javascript application
for processing, and emulate them for Daydream headsets.

BUG=389343, 666467
Committed: https://crrev.com/650300dcb6a24933d499d74b57a20705efacab74
Cr-Commit-Position: refs/heads/master@{#433002}

[klausw, 2016-11-17 20:39:32]

klausw@chromium.org changed reviewers:
+ bajones@chromium.org

[bajones, 2016-11-17 20:42:53]

https://codereview.chromium.org/2510083004/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2510083004/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell.cc:597: if (touch_pending_) {
Shouldn't this go in UpdateController under the if (html_interface_->GetMode()
== UiInterface::Mode::WEB_VR) branch?

[bajones, 2016-11-17 20:50:43]

On 2016/11/17 20:42:53, bajones wrote:
>
https://codereview.chromium.org/2510083004/diff/1/chrome/browser/android/vr_s...
> File chrome/browser/android/vr_shell/vr_shell.cc (right):
> 
>
https://codereview.chromium.org/2510083004/diff/1/chrome/browser/android/vr_s...
> chrome/browser/android/vr_shell/vr_shell.cc:597: if (touch_pending_) {
> Shouldn't this go in UpdateController under the if (html_interface_->GetMode()
> == UiInterface::Mode::WEB_VR) branch?

LGTM either way.

[klausw, 2016-11-17 21:00:00]

https://codereview.chromium.org/2510083004/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2510083004/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell.cc:597: if (touch_pending_) {
On 2016/11/17 20:42:53, bajones wrote:
> Shouldn't this go in UpdateController under the if (html_interface_->GetMode()
> == UiInterface::Mode::WEB_VR) branch?

Yes, that's a much better fit. Moved.

[klausw, 2016-11-17 21:00:28]

The CQ bit was checked by klausw@chromium.org

[klausw, 2016-11-17 21:00:28]

The patchset sent to the CQ was uploaded after l-g-t-m from bajones@chromium.org
Link to the patchset: https://codereview.chromium.org/2510083004/#ps20001
(title: "Move input processing")

[commit-bot: I haz the power, 2016-11-17 21:03:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mthiesse, 2016-11-17 21:03:55]

mthiesse@chromium.org changed reviewers:
+ mthiesse@chromium.org

[mthiesse, 2016-11-17 21:03:56]

https://codereview.chromium.org/2510083004/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2510083004/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:379: if (touch_pending_) {
This will only work for cardboard, also check if the controller button is down.

[mthiesse, 2016-11-17 21:04:00]

The CQ bit was unchecked by mthiesse@chromium.org

[klausw, 2016-11-17 21:25:16]

Description was changed from

==========
WebVR: enable Cardboard button compatibility

In native WebVR mode on a Cardboard style headset with capacitive touch
button, need to forward these touch events to the Javascript application
for processing. Do this as a separate handler, WebVR isn't currently
sharing VrShell's controller logic since the controller is supposed to
be handled by the individual WebVR application.

BUG=389343
==========

to

==========
WebVR: Fix Cardboard button processing

In native WebVR mode on a Cardboard style headset with capacitive touch
button, need to forward these touch events to the Javascript application
for processing, and emulate them for Daydream headsets.

BUG=389343,666467
==========

[klausw, 2016-11-17 21:32:08]

https://codereview.chromium.org/2510083004/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2510083004/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:379: if (touch_pending_) {
On 2016/11/17 21:03:56, mthiesse wrote:
> This will only work for cardboard, also check if the controller button is
down.

Done.

[mthiesse, 2016-11-17 21:33:32]

lgtm

[klausw, 2016-11-17 21:34:55]

The CQ bit was checked by klausw@chromium.org

[klausw, 2016-11-17 21:34:56]

The patchset sent to the CQ was uploaded after l-g-t-m from bajones@chromium.org
Link to the patchset: https://codereview.chromium.org/2510083004/#ps40001
(title: "Also support controller touchpad click for compatibility")

[commit-bot: I haz the power, 2016-11-17 21:36:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 22:57:49]

Description was changed from

==========
WebVR: Fix Cardboard button processing

In native WebVR mode on a Cardboard style headset with capacitive touch
button, need to forward these touch events to the Javascript application
for processing, and emulate them for Daydream headsets.

BUG=389343,666467
==========

to

==========
WebVR: Fix Cardboard button processing

In native WebVR mode on a Cardboard style headset with capacitive touch
button, need to forward these touch events to the Javascript application
for processing, and emulate them for Daydream headsets.

BUG=389343,666467
==========

[commit-bot: I haz the power, 2016-11-17 22:57:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 23:00:55]

Description was changed from

==========
WebVR: Fix Cardboard button processing

In native WebVR mode on a Cardboard style headset with capacitive touch
button, need to forward these touch events to the Javascript application
for processing, and emulate them for Daydream headsets.

BUG=389343,666467
==========

to

==========
WebVR: Fix Cardboard button processing

In native WebVR mode on a Cardboard style headset with capacitive touch
button, need to forward these touch events to the Javascript application
for processing, and emulate them for Daydream headsets.

BUG=389343,666467

Committed: https://crrev.com/650300dcb6a24933d499d74b57a20705efacab74
Cr-Commit-Position: refs/heads/master@{#433002}
==========

[commit-bot: I haz the power, 2016-11-17 23:00:56]

Patchset 3 (id:??) landed as
https://crrev.com/650300dcb6a24933d499d74b57a20705efacab74
Cr-Commit-Position: refs/heads/master@{#433002}