PlzNavigate: properly update NavigationHandle for 204/205 and download responses

content/browser/frame_host/navigation_handle_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigation_handle_impl.h"
 
 #include "base/debug/dump_without_crashing.h"
 #include "base/logging.h"
 #include "content/browser/browsing_data/clear_site_data_throttle.h"
 #include "content/browser/child_process_security_policy_impl.h"
@@ skipping 475 matching lines @@
   connection_info_ = connection_info;
   request_id_ = request_id;
   should_replace_current_entry_ = should_replace_current_entry;
   is_download_ = is_download;
   is_stream_ = is_stream;
   state_ = WILL_PROCESS_RESPONSE;
   ssl_status_ = ssl_status;
   complete_callback_ = callback;
   transfer_callback_ = transfer_callback;
 
+  // HTTP 204 (No Content) and HTTP 205 (Reset Content) responses should not
+  // commit; they leave the frame showing the previous page.
+  const bool is_204_205_response =
+      response_headers_ && (response_headers_->response_code() == 204 ||
+                            response_headers_->response_code() == 205);
+
+  // No need to cancel in non-PlzNavigate case. In that case, we will get
+  // DidFailProvisionalLoadWithError notification from the renderer to abort the
+  // navigation.
+  if (IsBrowserSideNavigationEnabled() &&
+      (is_204_205_response || is_download_)) {
+    net_error_code_ = net::ERR_ABORTED;
+    state_ = CANCELING;
+    RunCompleteCallback(NavigationThrottle::CANCEL_AND_IGNORE);
+    return;
+  }
+
   // Notify each throttle of the response.
   NavigationThrottle::ThrottleCheckResult result = CheckWillProcessResponse();
 
   // If the navigation is done processing the response, then it's ready to
   // commit. Determine which RenderFrameHost should render the response, based
   // on its site (after any redirects).
   // Note: if MaybeTransferAndProceed returns false, this means that this
   // NavigationHandle was deleted, so return immediately.
   if (result == NavigationThrottle::PROCEED && !MaybeTransferAndProceed())
     return;
@@ skipping 265 matching lines @@
     throttles_to_register.push_back(std::move(clear_site_data_throttle));
 
   if (throttles_to_register.size() > 0) {
     throttles_.insert(throttles_.begin(), throttles_to_register.begin(),
                       throttles_to_register.end());
     throttles_to_register.weak_clear();
   }
 }
 
 }  // namespace content