Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2510063002: Add icu libraries to fuzzer dependencies (Closed)

Created:
4 years, 1 month ago by miran.karic
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add icu libraries to fuzzer dependencies In component build, fuzzer did not link with icu libraries, causing errors. By adding icu libraries to dependencies fuzzer links correctly. BUG= TEST=fuzzer/* Committed: https://crrev.com/0ffe4fc390ac1848e80f6ae4e90abe29cd416bab Cr-Commit-Position: refs/heads/master@{#41098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M test/fuzzer/fuzzer.gyp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
miran.karic
PTAL. Added dependencies to gyp and gn. Though gn works without the change, I think ...
4 years, 1 month ago (2016-11-17 13:32:47 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 1 month ago (2016-11-18 08:10:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510063002/1
4 years, 1 month ago (2016-11-18 10:49:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 11:14:10 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 11:14:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ffe4fc390ac1848e80f6ae4e90abe29cd416bab
Cr-Commit-Position: refs/heads/master@{#41098}

Powered by Google App Engine
This is Rietveld 408576698