Add a count for Suggested Articles usage.

components/ntp_snippets/content_suggestions_metrics.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/content_suggestions_metrics.h"
 
 #include <string>
 #include <type_traits>
 
 #include "base/metrics/histogram.h"
 #include "base/metrics/histogram_macros.h"
+#include "base/metrics/user_metrics.h"
 #include "base/strings/stringprintf.h"
 #include "base/template_util.h"
 
+using base::RecordAction;
+using base::UserMetricsAction;

[Marc Treib, 2016/11/17 11:10:23]

nit: I'd prefer specifying the "base::" in the one place where it's used below.

[markusheintz_, 2016/11/17 13:48:47]

done

+
 namespace ntp_snippets {
 namespace metrics {
 
 namespace {
 
 const int kMaxSuggestionsPerCategory = 10;
 const int kMaxSuggestionsTotal = 50;
 
 const char kHistogramCountOnNtpOpened[] =
     "NewTabPage.ContentSuggestions.CountOnNtpOpened";
@@ skipping 141 matching lines @@
 // bucket is increased.
 void RecordContentSuggestionsUsage() {
   const int kBucketSizeMins = 20;
   const int kNumBuckets = 24 * 60 / kBucketSizeMins;
 
   base::Time::Exploded now_exploded;
   base::Time::Now().LocalExplode(&now_exploded);
   size_t bucket =
       (now_exploded.hour * 60 + now_exploded.minute) / kBucketSizeMins;
 
-  UMA_HISTOGRAM_ENUMERATION(kHistogramUsageTimeLocal, bucket, kNumBuckets);
+  UMA_HISTOGRAM_ENUMERATION(kHistogramArticlesUsageTimeLocal, bucket,

[Marc Treib, 2016/11/17 11:10:23]

Bad rebase? You renamed the constant here, but not above where it's defined.

[markusheintz_, 2016/11/17 13:48:46]

Done.

+                            kNumBuckets);
 
-  LOG(ERROR) << " ****************** Zine Usage";
+  RecordAction(
+      UserMetricsAction("NewTabPage_ContentSuggestions_ArticlesUsageCount"));

[Marc Treib, 2016/11/17 11:10:23]

"Count" is implied by the fact that it's a UserAction :)
"NewTabPage_ContentSuggestions_ArticlesUsed" ?

[markusheintz_, 2016/11/17 13:48:46]

Done.

 }
 
 }  // namespace
 
 void OnPageShown(
     const std::vector<std::pair<Category, int>>& suggestions_per_category) {
   int suggestions_total = 0;
   for (const std::pair<Category, int>& item : suggestions_per_category) {
     LogCategoryHistogramEnumeration(kHistogramCountOnNtpOpened, item.first,
                                     item.second, kMaxSuggestionsPerCategory);
@@ skipping 104 matching lines @@
 
 void OnMoreButtonClicked(Category category, int position) {
   // The "more" card can appear in addition to the actual suggestions, so add
   // one extra bucket to this histogram.
   LogCategoryHistogramEnumeration(kHistogramMoreButtonClicked, category,
                                   position, kMaxSuggestionsPerCategory + 1);
 }
 
 }  // namespace metrics
 }  // namespace ntp_snippets