Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2510043004: [x86] Also deal with holey arrays in the Apply builtin. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Franzi, Yang
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, v8-arm-ports_googlegroups.com, v8-mips-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x86] Also deal with holey arrays in the Apply builtin. Add fast paths for holey smi and object arrays to Function.prototype.apply, Reflect.apply and Reflect.construct. R=yangguo@chromium.org Committed: https://crrev.com/d4f01b8a65ec02250c3f2b52b9a5e335ff513d98 Cr-Commit-Position: refs/heads/master@{#41108}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -14 lines) Patch
M src/builtins/ia32/builtins-ia32.cc View 4 chunks +34 lines, -7 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 4 chunks +31 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 1 month ago (2016-11-18 12:36:46 UTC) #1
Benedikt Meurer
Yang: PTAL (Fix for https://github.com/nodejs/node/pull/9643) Franzi: FYI ARM/MIPS folks: Please port this.
4 years, 1 month ago (2016-11-18 12:37:58 UTC) #5
Yang
On 2016/11/18 12:37:58, Benedikt Meurer wrote: > Yang: PTAL (Fix for https://github.com/nodejs/node/pull/9643) > Franzi: FYI ...
4 years, 1 month ago (2016-11-18 12:46:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2510043004/1
4 years, 1 month ago (2016-11-18 12:50:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 13:31:16 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 13:31:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4f01b8a65ec02250c3f2b52b9a5e335ff513d98
Cr-Commit-Position: refs/heads/master@{#41108}

Powered by Google App Engine
This is Rietveld 408576698