[Device Service] Move PowerMonitor into the Device Service

content/child/child_thread_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/child_thread_impl.h"
 
 #include <signal.h>
 #include <string>
 #include <utility>
 
@@ skipping 49 matching lines @@
 #include "ipc/ipc_logging.h"
 #include "ipc/ipc_platform_file.h"
 #include "ipc/ipc_sync_channel.h"
 #include "ipc/ipc_sync_message_filter.h"
 #include "mojo/edk/embedder/embedder.h"
 #include "mojo/edk/embedder/named_platform_channel_pair.h"
 #include "mojo/edk/embedder/platform_channel_pair.h"
 #include "mojo/edk/embedder/scoped_ipc_support.h"
 #include "mojo/public/cpp/system/buffer.h"
 #include "mojo/public/cpp/system/platform_handle.h"
+#include "services/device/public/cpp/constants.h"
 #include "services/service_manager/public/cpp/connector.h"
 #include "services/service_manager/public/cpp/interface_factory.h"
 #include "services/service_manager/public/cpp/interface_provider.h"
 #include "services/service_manager/public/cpp/interface_registry.h"
 #include "services/service_manager/runner/common/client_util.h"
 
 #if defined(OS_POSIX)
 #include "base/posix/global_descriptors.h"
 #include "content/public/common/content_descriptors.h"
 #endif
@@ skipping 451 matching lines @@
   channel_->AddFilter(service_worker_message_filter_->GetFilter());
 
   if (!IsInBrowserProcess()) {
     // In single process mode, browser-side tracing and memory will cover the
     // whole process including renderers.
     channel_->AddFilter(new tracing::ChildTraceMessageFilter(
         ChildProcess::current()->io_task_runner()));
     channel_->AddFilter(new ChildMemoryMessageFilter());
   }
 
-  // In single process mode we may already have a power monitor
+  // In single process mode we may already have a power monitor.
   if (!base::PowerMonitor::Get()) {
+    std::unique_ptr<service_manager::Connection> device_connection;
+    service_manager::InterfaceProvider* remote_interfaces = nullptr;
+    if (service_manager_connection_) {

[leonhsl(Using Gerrit), 2016/11/17 10:28:03]

Should we use DCHECK(service_manager_connection_) here? I'm not sure whether
child processes are all acting as service or not.

[blundell, 2016/11/22 16:46:44]

I'm not sure either. Ken?

[Ken Rockot(use gerrit already), 2016/11/22 17:23:40]

There are still a few edge cases where there is no ServiceManagerConnection, so
no, it's not OK to DCHECK here. As a nit though, I would just do

  if (!base::PowerMonitor::Get() && service_manager_connection_) { 
     // ...

+      device_connection = service_manager_connection_->GetConnector()->Connect(
+          device::kDeviceServiceName);
+      remote_interfaces = device_connection->GetRemoteInterfaces();
+    }
     std::unique_ptr<device::PowerMonitorBroadcastSource> power_monitor_source(
-        new device::PowerMonitorBroadcastSource(GetRemoteInterfaces()));
+        new device::PowerMonitorBroadcastSource(remote_interfaces));
 
     power_monitor_.reset(
         new base::PowerMonitor(std::move(power_monitor_source)));
   }
 
 #if defined(OS_POSIX)
   // Check that --process-type is specified so we don't do this in unit tests
   // and single-process mode.
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kProcessType))
     channel_->AddFilter(new SuicideOnChannelErrorFilter());
@@ skipping 361 matching lines @@
   connected_to_browser_ = true;
   child_info_ = local_info;
   browser_info_ = remote_info;
 }
 
 bool ChildThreadImpl::IsInBrowserProcess() const {
   return static_cast<bool>(browser_process_io_runner_);
 }
 
 }  // namespace content