cc: prevent TileManager raster/eviction tile iterators copy.

cc: prevent TileManager raster/eviction tile iterators copy.

This patch ensures that iterators cannot be copied..
Since we rely on a member heap that points to another member vector,
we can't do a naive copy. Instead we would have to reconstruct the
heap to point to the new members, but it's better to just restrict
copy altogether.

R=enne

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267042

[vmpstr, 2014-04-25 20:12:31]

Please take a look.

[vmpstr, 2014-04-29 17:07:59]

On 2014/04/25 20:12:31, vmpstr wrote:
> Please take a look.

ping

[enne (OOO), 2014-04-29 18:08:17]

When do these need to be copied? If they don't, DISALLOW_COPY_AND_ASSIGN seems
like a better answer to avoid implicitly and unintentionally doing vector
copies.

[vmpstr, 2014-04-29 18:39:13]

On 2014/04/29 18:08:17, enne wrote:
> When do these need to be copied? If they don't, DISALLOW_COPY_AND_ASSIGN seems
> like a better answer to avoid implicitly and unintentionally doing vector
> copies.

tldr: Changed!

Makes sense. I needed to do a copy because I lazily initialized eviction
iterator,
but that changed to have a lazy initialization right in the constructor.

PTAL.

[enne (OOO), 2014-04-29 18:47:29]

lgtm

[vmpstr, 2014-04-29 18:49:39]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2014-04-29 18:51:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vmpstr@chromium.org/251003002/10001

[commit-bot: I haz the power, 2014-04-29 19:18:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 19:18:45]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium

[vmpstr, 2014-04-29 23:09:23]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2014-04-29 23:10:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vmpstr@chromium.org/251003002/10001

[commit-bot: I haz the power, 2014-04-30 02:01:32]

Change committed as 267042