third_party/WebKit/LayoutTests/imported/wpt/webrtc/RTCPeerConnectionIceEvent-constructor.html - Issue 2509983007: Upstream RTCDataChannelEvent and RTCPeerConnectionIceEvent ctor tests

Unified Diff: third_party/WebKit/LayoutTests/imported/wpt/webrtc/RTCPeerConnectionIceEvent-constructor.html

Issue 2509983007: Upstream RTCDataChannelEvent and RTCPeerConnectionIceEvent ctor tests (Closed)

Patch Set: tweak paths and comment out url Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Index: third_party/WebKit/LayoutTests/imported/wpt/webrtc/RTCPeerConnectionIceEvent-constructor.html

diff --git a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html b/third_party/WebKit/LayoutTests/imported/wpt/webrtc/RTCPeerConnectionIceEvent-constructor.html

similarity index 69%

rename from third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html

rename to third_party/WebKit/LayoutTests/imported/wpt/webrtc/RTCPeerConnectionIceEvent-constructor.html

index 55f823b9704fee4c87ea565afcaacbd928182ad0..22d9d4bb591aa07d4bcd0762b7b65f02ab162b2a 100644

--- a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnectionIceEvent-constructor.html

+++ b/third_party/WebKit/LayoutTests/imported/wpt/webrtc/RTCPeerConnectionIceEvent-constructor.html

@@ -1,8 +1,8 @@

<!DOCTYPE html>

<title>RTCPeerConnectionIceEvent constructor</title>

-<script src="../../resources/testharness.js"></script>

-<script src="../../resources/testharnessreport.js"></script>

+<script src="/resources/testharness.js"></script>

+<script src="/resources/testharnessreport.js"></script>

test(function() {

assert_equals(RTCPeerConnectionIceEvent.length, 1);

@@ -10,26 +10,24 @@ test(function() {

assert_equals(e.candidate, null);

assert_false(e.bubbles);

assert_false(e.cancelable);

-}, 'RTCPeerConnectionIceEvent constructor with no candidate attribute provided');

+}, 'RTCPeerConnectionIceEvent constructor with no candidate provided.');

test(function() {

var e = new RTCPeerConnectionIceEvent('type', { candidate: null });

assert_equals(e.candidate, null);

-}, 'RTCPeerConnectionIceEvent constructor with cnadidate passed as null.');

+}, 'RTCPeerConnectionIceEvent constructor with candidate passed as null.');

test(function() {

var e = new RTCPeerConnectionIceEvent('type', { candidate: undefined });

assert_equals(e.candidate, null);

-}, 'RTCPeerConnectionIceEvent constructor with candidate passed as "undefined".');

+}, 'RTCPeerConnectionIceEvent constructor with candidate passed as undefined.');

test(function() {

var c = new RTCIceCandidate({ candidate: 'candidate', sdpMid: 'sdpMid', sdpMLineIndex: 1 });

var e = new RTCPeerConnectionIceEvent('type', { candidate: c, url: 'url', bubbles: true, cancelable: true});

assert_equals(e.type, 'type');

assert_equals(e.candidate, c);

- // TODO(lunalu): When url is added to RTCPeerConnectionIceEventInitializer,

- // update the assertion to be: "assert_equals(e.url, 'url);".

- assert_equals(e.url, undefined);

+ // assert_equals(e.url, 'url');

hta - Chromium 2016/11/22 22:06:52 Shouldn't we just add the assertion and let the te

foolip 2016/11/23 09:43:08 The trouble, as I see it, is that it will make the

assert_true(e.bubbles);

assert_true(e.cancelable);

}, 'RTCPeerConnectionIceEvent constructor with full arguments.');

« no previous file with comments | « third_party/WebKit/LayoutTests/imported/wpt/webrtc/RTCDataChannelEvent-constructor.html ('k') | no next file » | no next file with comments »