Print Preview: Fix handling of printers without capabilities.

Print Preview: Fix handling of printers without capabilities.

BUG=666672
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/92a1b39f7a3fc31aedcf3ebfc50a297b95882bae
Cr-Commit-Position: refs/heads/master@{#433263}

[Lei Zhang, 2016-11-18 09:36:38]

Description was changed from

==========
Print Preview: Fix handling of printers without capabilities.

BUG=666672
==========

to

==========
Print Preview: Fix handling of printers without capabilities.

BUG=666672
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Lei Zhang, 2016-11-18 09:39:15]

thestig@chromium.org changed reviewers:
+ dpapad@chromium.org, skau@chromium.org

[Lei Zhang, 2016-11-18 09:39:15]

See bug for the list of CLs to blame.
- We should always set the capabilities, even to an empty dictionary.
- We cannot assume printers with no capabilities have fields.

[Lei Zhang, 2016-11-18 09:39:22]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 09:39:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 10:31:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 10:31:15]

Dry run: This issue passed the CQ dry run.

[skau, 2016-11-18 16:29:27]

lgtm

Thanks for the fix.  Sorry about the bug.  Is there a way to write an
integration test for this since the contract isn't obvious?

[dpapad, 2016-11-18 18:33:49]

LGTM. We should probably add a test for this (in a follow up CL).

[Lei Zhang, 2016-11-18 19:10:22]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-11-18 19:10:42]

On 2016/11/18 18:33:49, dpapad wrote:
> LGTM. We should probably add a test for this (in a follow up CL).

Sure. Will add JS tests.

[commit-bot: I haz the power, 2016-11-18 19:11:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 19:29:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-18 19:33:15]

Description was changed from

==========
Print Preview: Fix handling of printers without capabilities.

BUG=666672
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Print Preview: Fix handling of printers without capabilities.

BUG=666672
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/92a1b39f7a3fc31aedcf3ebfc50a297b95882bae
Cr-Commit-Position: refs/heads/master@{#433263}
==========

[commit-bot: I haz the power, 2016-11-18 19:33:16]

Patchset 1 (id:??) landed as
https://crrev.com/92a1b39f7a3fc31aedcf3ebfc50a297b95882bae
Cr-Commit-Position: refs/heads/master@{#433263}