Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2509983006: Print Preview: Fix handling of printers without capabilities. (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
skau, dpapad
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Print Preview: Fix handling of printers without capabilities. BUG=666672 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/92a1b39f7a3fc31aedcf3ebfc50a297b95882bae Cr-Commit-Position: refs/heads/master@{#433263}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/browser/resources/print_preview/data/destination_store.js View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/printer_capabilities.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Lei Zhang
See bug for the list of CLs to blame. - We should always set the ...
4 years, 1 month ago (2016-11-18 09:39:15 UTC) #3
skau
lgtm Thanks for the fix. Sorry about the bug. Is there a way to write ...
4 years, 1 month ago (2016-11-18 16:29:27 UTC) #8
dpapad
LGTM. We should probably add a test for this (in a follow up CL).
4 years, 1 month ago (2016-11-18 18:33:49 UTC) #9
Lei Zhang
On 2016/11/18 18:33:49, dpapad wrote: > LGTM. We should probably add a test for this ...
4 years, 1 month ago (2016-11-18 19:10:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509983006/1
4 years, 1 month ago (2016-11-18 19:11:03 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 19:29:22 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 19:33:16 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92a1b39f7a3fc31aedcf3ebfc50a297b95882bae
Cr-Commit-Position: refs/heads/master@{#433263}

Powered by Google App Engine
This is Rietveld 408576698