content/browser/compositor/software_output_device_mac.mm - Issue 2509983004: Revert "Change call-sites now that SkCanvas is not ref-counted"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/software_output_device_mac.mm

Issue 2509983004: Revert "Change call-sites now that SkCanvas is not ref-counted" (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/compositor/software_output_device_mac.mm

diff --git a/content/browser/compositor/software_output_device_mac.mm b/content/browser/compositor/software_output_device_mac.mm

index 1db33824c81f6d995ece9fc47357560095a79008..bff1570c1fe1752100621c31f69835fe7d72c5fc 100644

--- a/content/browser/compositor/software_output_device_mac.mm

+++ b/content/browser/compositor/software_output_device_mac.mm

@@ -114,8 +114,8 @@ SkCanvas* SoftwareOutputDeviceMac::BeginPaint(

IOSurfaceGetBaseAddress(io_surfaces_[current_index_]));

size_t stride = IOSurfaceGetBytesPerRow(io_surfaces_[current_index_]);

- canvas_ = SkCanvas::MakeRasterDirectN32(pixel_size_.width(),

- pixel_size_.height(), pixels, stride);

+ canvas_ = sk_sp<SkCanvas>(SkCanvas::NewRasterDirectN32(

+ pixel_size_.width(), pixel_size_.height(), pixels, stride));

CopyPreviousBufferDamage(SkRegion(gfx::RectToSkIRect(new_damage_rect)));