Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Side by Side Diff: cc/test/fake_content_layer_client.cc

Issue 2509983004: Revert "Change call-sites now that SkCanvas is not ref-counted" (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/raster/gpu_raster_buffer_provider.cc ('k') | cc/test/solid_color_content_layer_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/test/fake_content_layer_client.h" 5 #include "cc/test/fake_content_layer_client.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "cc/playback/clip_display_item.h" 9 #include "cc/playback/clip_display_item.h"
10 #include "cc/playback/display_item_list_settings.h" 10 #include "cc/playback/display_item_list_settings.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 FakeContentLayerClient::PaintContentsToDisplayList( 51 FakeContentLayerClient::PaintContentsToDisplayList(
52 PaintingControlSetting painting_control) { 52 PaintingControlSetting painting_control) {
53 // Cached picture is used because unit tests expect to be able to 53 // Cached picture is used because unit tests expect to be able to
54 // use GatherPixelRefs. 54 // use GatherPixelRefs.
55 DisplayItemListSettings settings; 55 DisplayItemListSettings settings;
56 settings.use_cached_picture = display_list_use_cached_picture_; 56 settings.use_cached_picture = display_list_use_cached_picture_;
57 scoped_refptr<DisplayItemList> display_list = 57 scoped_refptr<DisplayItemList> display_list =
58 DisplayItemList::Create(settings); 58 DisplayItemList::Create(settings);
59 display_list->SetRetainVisualRectsForTesting(true); 59 display_list->SetRetainVisualRectsForTesting(true);
60 SkPictureRecorder recorder; 60 SkPictureRecorder recorder;
61 sk_sp<SkCanvas> canvas;
61 62
62 for (RectPaintVector::const_iterator it = draw_rects_.begin(); 63 for (RectPaintVector::const_iterator it = draw_rects_.begin();
63 it != draw_rects_.end(); ++it) { 64 it != draw_rects_.end(); ++it) {
64 const gfx::RectF& draw_rect = it->first; 65 const gfx::RectF& draw_rect = it->first;
65 const SkPaint& paint = it->second; 66 const SkPaint& paint = it->second;
66 SkCanvas* canvas = recorder.beginRecording(gfx::RectFToSkRect(draw_rect)); 67 canvas = sk_ref_sp(recorder.beginRecording(gfx::RectFToSkRect(draw_rect)));
67 canvas->drawRect(gfx::RectFToSkRect(draw_rect), paint); 68 canvas->drawRect(gfx::RectFToSkRect(draw_rect), paint);
68 display_list->CreateAndAppendDrawingItem<DrawingDisplayItem>( 69 display_list->CreateAndAppendDrawingItem<DrawingDisplayItem>(
69 ToEnclosingRect(draw_rect), recorder.finishRecordingAsPicture()); 70 ToEnclosingRect(draw_rect), recorder.finishRecordingAsPicture());
70 } 71 }
71 72
72 for (ImageVector::const_iterator it = draw_images_.begin(); 73 for (ImageVector::const_iterator it = draw_images_.begin();
73 it != draw_images_.end(); ++it) { 74 it != draw_images_.end(); ++it) {
74 if (!it->transform.IsIdentity()) { 75 if (!it->transform.IsIdentity()) {
75 display_list->CreateAndAppendPairedBeginItem<TransformDisplayItem>( 76 display_list->CreateAndAppendPairedBeginItem<TransformDisplayItem>(
76 it->transform); 77 it->transform);
77 } 78 }
78 SkCanvas* canvas = 79 canvas = sk_ref_sp(
79 recorder.beginRecording(it->image->width(), it->image->height()); 80 recorder.beginRecording(it->image->width(), it->image->height()));
80 canvas->drawImage(it->image.get(), it->point.x(), it->point.y(), 81 canvas->drawImage(it->image.get(), it->point.x(), it->point.y(),
81 &it->paint); 82 &it->paint);
82 display_list->CreateAndAppendDrawingItem<DrawingDisplayItem>( 83 display_list->CreateAndAppendDrawingItem<DrawingDisplayItem>(
83 PaintableRegion(), recorder.finishRecordingAsPicture()); 84 PaintableRegion(), recorder.finishRecordingAsPicture());
84 if (!it->transform.IsIdentity()) { 85 if (!it->transform.IsIdentity()) {
85 display_list->CreateAndAppendPairedEndItem<EndTransformDisplayItem>(); 86 display_list->CreateAndAppendPairedEndItem<EndTransformDisplayItem>();
86 } 87 }
87 } 88 }
88 89
89 if (fill_with_nonsolid_color_) { 90 if (fill_with_nonsolid_color_) {
90 gfx::Rect draw_rect = PaintableRegion(); 91 gfx::Rect draw_rect = PaintableRegion();
91 bool red = true; 92 bool red = true;
92 while (!draw_rect.IsEmpty()) { 93 while (!draw_rect.IsEmpty()) {
93 SkPaint paint; 94 SkPaint paint;
94 paint.setColor(red ? SK_ColorRED : SK_ColorBLUE); 95 paint.setColor(red ? SK_ColorRED : SK_ColorBLUE);
95 SkCanvas* canvas = recorder.beginRecording(gfx::RectToSkRect(draw_rect)); 96 canvas = sk_ref_sp(recorder.beginRecording(gfx::RectToSkRect(draw_rect)));
96 canvas->drawIRect(gfx::RectToSkIRect(draw_rect), paint); 97 canvas->drawIRect(gfx::RectToSkIRect(draw_rect), paint);
97 display_list->CreateAndAppendDrawingItem<DrawingDisplayItem>( 98 display_list->CreateAndAppendDrawingItem<DrawingDisplayItem>(
98 draw_rect, recorder.finishRecordingAsPicture()); 99 draw_rect, recorder.finishRecordingAsPicture());
99 draw_rect.Inset(1, 1); 100 draw_rect.Inset(1, 1);
100 } 101 }
101 } 102 }
102 103
103 display_list->Finalize(); 104 display_list->Finalize();
104 return display_list; 105 return display_list;
105 } 106 }
106 107
107 bool FakeContentLayerClient::FillsBoundsCompletely() const { return false; } 108 bool FakeContentLayerClient::FillsBoundsCompletely() const { return false; }
108 109
109 size_t FakeContentLayerClient::GetApproximateUnsharedMemoryUsage() const { 110 size_t FakeContentLayerClient::GetApproximateUnsharedMemoryUsage() const {
110 return reported_memory_usage_; 111 return reported_memory_usage_;
111 } 112 }
112 113
113 } // namespace cc 114 } // namespace cc
OLDNEW
« no previous file with comments | « cc/raster/gpu_raster_buffer_provider.cc ('k') | cc/test/solid_color_content_layer_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698