Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Side by Side Diff: cc/playback/discardable_image_map.h

Issue 2509983004: Revert "Change call-sites now that SkCanvas is not ref-counted" (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/output/software_renderer.cc ('k') | cc/playback/discardable_image_map.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_PLAYBACK_DISCARDABLE_IMAGE_MAP_H_ 5 #ifndef CC_PLAYBACK_DISCARDABLE_IMAGE_MAP_H_
6 #define CC_PLAYBACK_DISCARDABLE_IMAGE_MAP_H_ 6 #define CC_PLAYBACK_DISCARDABLE_IMAGE_MAP_H_
7 7
8 #include <unordered_map> 8 #include <unordered_map>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 23 matching lines...) Expand all
34 class CC_EXPORT ScopedMetadataGenerator { 34 class CC_EXPORT ScopedMetadataGenerator {
35 public: 35 public:
36 ScopedMetadataGenerator(DiscardableImageMap* image_map, 36 ScopedMetadataGenerator(DiscardableImageMap* image_map,
37 const gfx::Size& bounds); 37 const gfx::Size& bounds);
38 ~ScopedMetadataGenerator(); 38 ~ScopedMetadataGenerator();
39 39
40 SkCanvas* canvas() { return metadata_canvas_.get(); } 40 SkCanvas* canvas() { return metadata_canvas_.get(); }
41 41
42 private: 42 private:
43 DiscardableImageMap* image_map_; 43 DiscardableImageMap* image_map_;
44 std::unique_ptr<SkCanvas> metadata_canvas_; 44 sk_sp<SkCanvas> metadata_canvas_;
45 }; 45 };
46 46
47 DiscardableImageMap(); 47 DiscardableImageMap();
48 ~DiscardableImageMap(); 48 ~DiscardableImageMap();
49 49
50 bool empty() const { return all_images_.empty(); } 50 bool empty() const { return all_images_.empty(); }
51 void GetDiscardableImagesInRect(const gfx::Rect& rect, 51 void GetDiscardableImagesInRect(const gfx::Rect& rect,
52 const gfx::SizeF& raster_scales, 52 const gfx::SizeF& raster_scales,
53 std::vector<DrawImage>* images) const; 53 std::vector<DrawImage>* images) const;
54 Region GetRegionForImage(uint32_t image_id) const; 54 Region GetRegionForImage(uint32_t image_id) const;
55 55
56 private: 56 private:
57 friend class ScopedMetadataGenerator; 57 friend class ScopedMetadataGenerator;
58 friend class DiscardableImageMapTest; 58 friend class DiscardableImageMapTest;
59 59
60 std::unique_ptr<SkCanvas> BeginGeneratingMetadata(const gfx::Size& bounds); 60 sk_sp<SkCanvas> BeginGeneratingMetadata(const gfx::Size& bounds);
61 void EndGeneratingMetadata(); 61 void EndGeneratingMetadata();
62 62
63 std::vector<std::pair<DrawImage, gfx::Rect>> all_images_; 63 std::vector<std::pair<DrawImage, gfx::Rect>> all_images_;
64 ImageToRegionMap image_id_to_region_; 64 ImageToRegionMap image_id_to_region_;
65 65
66 RTree images_rtree_; 66 RTree images_rtree_;
67 }; 67 };
68 68
69 } // namespace cc 69 } // namespace cc
70 70
71 #endif // CC_PLAYBACK_DISCARDABLE_IMAGE_MAP_H_ 71 #endif // CC_PLAYBACK_DISCARDABLE_IMAGE_MAP_H_
OLDNEW
« no previous file with comments | « cc/output/software_renderer.cc ('k') | cc/playback/discardable_image_map.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698