Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2509943002: NO LONGER FOR REVIEW - [ash-md] Implements a square focus rectangle for ToggleButton (Closed)

Created:
4 years, 1 month ago by varkha
Modified:
4 years, 1 month ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Implements a square focus rectangle for ToggleButton BUG=652492 TEST=manual Bring focus using Tab to a toggle button in Network detailed page. (focus rectangle appears). Press Space (toggle switches) Press Enter (toggle switches) Tab (focus switches to the next row).

Patch Set 1 #

Patch Set 2 : [ash-md] Implements a square focus rectangle for ToggleButton (rebased) #

Total comments: 1

Patch Set 3 : [ash-md] Implements a square focus rectangle for ToggleButton (most visible discrepancies) #

Patch Set 4 : [ash-md] Implements a square focus rectangle for ToggleButton (toggles that work) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -27 lines) Patch
M ash/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ash/common/system/chromeos/bluetooth/tray_bluetooth.cc View 1 2 4 chunks +3 lines, -7 lines 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_list_view.cc View 1 2 4 chunks +4 lines, -7 lines 0 comments Download
M ash/common/system/chromeos/network/network_list_md.cc View 1 2 6 chunks +7 lines, -13 lines 0 comments Download
A ash/common/system/tray/system_menu_toggle_button.h View 1 2 3 1 chunk +74 lines, -0 lines 0 comments Download
A ash/common/system/tray/system_menu_toggle_button.cc View 1 2 3 1 chunk +122 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
varkha
tdanderson@, can you please take a look?
4 years, 1 month ago (2016-11-17 01:11:33 UTC) #7
varkha
https://codereview.chromium.org/2509943002/diff/20001/ash/common/system/tray/system_menu_toggle_button.h File ash/common/system/tray/system_menu_toggle_button.h (right): https://codereview.chromium.org/2509943002/diff/20001/ash/common/system/tray/system_menu_toggle_button.h#newcode25 ash/common/system/tray/system_menu_toggle_button.h:25: // crbug.com/614453. self review - remove the 3 lines ...
4 years, 1 month ago (2016-11-17 01:51:48 UTC) #9
Evan Stade
why have we introduced a wrapper instead of adding focus states to ToggleButton?
4 years, 1 month ago (2016-11-17 01:59:01 UTC) #10
Evan Stade
On 2016/11/17 01:59:01, Evan Stade wrote: > why have we introduced a wrapper instead of ...
4 years, 1 month ago (2016-11-17 02:13:44 UTC) #11
varkha
I think the best will be best to add ability to size to the right ...
4 years, 1 month ago (2016-11-17 02:50:59 UTC) #12
Evan Stade
Can we go with the simplest approach for now, i.e. add something to ToggleButton and ...
4 years, 1 month ago (2016-11-17 03:27:38 UTC) #14
tdanderson
On 2016/11/17 03:27:38, Evan Stade wrote: > Can we go with the simplest approach for ...
4 years, 1 month ago (2016-11-17 04:28:30 UTC) #15
varkha
On 2016/11/17 03:27:38, Evan Stade wrote: > Can we go with the simplest approach for ...
4 years, 1 month ago (2016-11-17 05:06:09 UTC) #16
varkha
4 years, 1 month ago (2016-11-17 07:16:03 UTC) #17

Powered by Google App Engine
This is Rietveld 408576698