Drag-and-drop: Target drag messages (the sequel).

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <stddef.h>
 
 #include <cmath>
 #include <utility>
@@ skipping 62 matching lines @@
 #include "content/browser/renderer_host/text_input_manager.h"
 #include "content/browser/screen_orientation/screen_orientation_dispatcher_host_impl.h"
 #include "content/browser/site_instance_impl.h"
 #include "content/browser/web_contents/web_contents_view_child_frame.h"
 #include "content/browser/web_contents/web_contents_view_guest.h"
 #include "content/browser/webui/generic_handler.h"
 #include "content/browser/webui/web_ui_controller_factory_registry.h"
 #include "content/browser/webui/web_ui_impl.h"
 #include "content/common/browser_plugin/browser_plugin_constants.h"
 #include "content/common/browser_plugin/browser_plugin_messages.h"
+#include "content/common/drag_messages.h"
 #include "content/common/frame_messages.h"
 #include "content/common/input_messages.h"
 #include "content/common/page_messages.h"
 #include "content/common/page_state_serialization.h"
 #include "content/common/render_message_filter.mojom.h"
 #include "content/common/site_isolation_policy.h"
 #include "content/common/view_messages.h"
 #include "content/public/browser/ax_event_notification_details.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_plugin_guest_manager.h"
@@ skipping 2918 matching lines @@
       Source<WebContents>(this),
       Details<const ResourceRedirectDetails>(&details));
 }
 
 void WebContentsImpl::NotifyWebContentsFocused() {
   for (auto& observer : observers_)
     observer.OnWebContentsFocused();
 }
 
 void WebContentsImpl::SystemDragEnded() {
-  // TODO(paulmeyer): This will need to target the correct specific RWH to work
-  // with OOPIF.
-  if (GetRenderViewHost())
-    GetRenderViewHost()->GetWidget()->DragSourceSystemDragEnded();
+  // TODO(lukasza/paulmeyer): Rather then sending the IPC to all widgets in the
+  // frame tree, it might be possible to send the IPC only to the widget where
+  // drag-start has fired.
+  for (RenderWidgetHostView* rwhv : GetRenderWidgetHostViewsInTree()) {
+    RenderWidgetHostViewBase* rwhvb =
+        static_cast<RenderWidgetHostViewBase*>(rwhv);
+    RenderWidgetHost* rwh = rwhvb->GetRenderWidgetHost();
+    rwh->Send(new DragMsg_SourceSystemDragEnded(rwh->GetRoutingID()));

[dcheng, 2016/11/17 17:44:19]

We should definitely only be sending this to the drag source. The renderer
happens to guard against dragends that should be no-ops, but we shouldn't be
relying on that.

(Looking at this more, it seems like our DnD code is generally confused about
what it should be doing here: I think we're actually sending both
DragMsg_SourceEnded (which dispatches the dragend event) and
DragMsg_SourceSystemDragEnded in the normal DnD completion scenario... but it's
OK to fix that later)

+  }
+
   if (browser_plugin_embedder_.get())
     browser_plugin_embedder_->SystemDragEnded();
 }
 
 void WebContentsImpl::UserGestureDone() {
   OnUserInteraction(GetRenderViewHost()->GetWidget(),
                     blink::WebInputEvent::Undefined);
 }
 
 void WebContentsImpl::SetClosedByUserGesture(bool value) {
@@ skipping 2187 matching lines @@
   dialog_manager_ = dialog_manager;
 }
 
 void WebContentsImpl::RemoveBindingSet(const std::string& interface_name) {
   auto it = binding_sets_.find(interface_name);
   if (it != binding_sets_.end())
     binding_sets_.erase(it);
 }
 
 }  // namespace content