Issue 250993003: Make getAttributeNS return null instead of empty string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 250993003: Make getAttributeNS return null instead of empty string (Closed)

Created:
6 years, 8 months ago by rwlbuis

Modified:
6 years, 7 months ago

Reviewers:
arv (Not doing code reviews), adamk, eseidel

CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, ojan, dglazkov+blink, adamk+blink_chromium.org, rwlbuis, watchdog-blink-watchlist_google.com, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Make getAttributeNS return null instead of empty string Make getAttributeNS return null instead of empty string when no match is found, like getAttribute does. This is specified in whatwg DOM and matches Firefox: http://dom.spec.whatwg.org/#concept-element-attributes-get BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172706

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	LayoutTests/fast/dom/Element/attribute-uppercase-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/core/dom/Element.idl	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/250993003/1

6 years, 8 months ago (2014-04-26 23:33:29 UTC) #3

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages