Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2509873003: CompositorViewHolder is source of truth for viewports (Closed)

Created:
4 years, 1 month ago by mdjones
Modified:
4 years ago
CC:
agrieve+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CompositorViewHolder is source of truth for viewports This change makes the CompositorViewHolder responsible for knowing what the window and visible viewports are. Any class that needs to know this information can pull it from the CompositorViewHolder (a LayoutManagerHost) instead of having it pushed or caching it. This removes a fair amount of state and complication in LayoutManager. BUG=662427 Committed: https://crrev.com/fd6719290c9dce87292ea653ac370542014030c7 Committed: https://crrev.com/7b2ace3be27bcaa12f371215c435d4cd59c5ff5d Cr-Original-Commit-Position: refs/heads/master@{#433916} Cr-Commit-Position: refs/heads/master@{#433965}

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : update tests #

Patch Set 4 : fix test #

Patch Set 5 : rebase #

Patch Set 6 : fix test merge conflict #

Messages

Total messages: 22 (12 generated)
mdjones
ptal
4 years, 1 month ago (2016-11-18 16:54:46 UTC) #2
aelias_OOO_until_Jul13
lgtm
4 years, 1 month ago (2016-11-18 22:10:38 UTC) #3
David Trainor- moved to gerrit
lgtm
4 years ago (2016-11-21 20:17:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509873003/80001
4 years ago (2016-11-22 17:34:27 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-11-22 18:16:53 UTC) #10
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/fd6719290c9dce87292ea653ac370542014030c7 Cr-Commit-Position: refs/heads/master@{#433916}
4 years ago (2016-11-22 18:19:33 UTC) #12
Maria
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2524833002/ by mariakhomenko@chromium.org. ...
4 years ago (2016-11-22 19:10:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509873003/100001
4 years ago (2016-11-22 19:54:58 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years ago (2016-11-22 20:31:20 UTC) #20
commit-bot: I haz the power
4 years ago (2016-11-22 20:35:22 UTC) #22
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/7b2ace3be27bcaa12f371215c435d4cd59c5ff5d
Cr-Commit-Position: refs/heads/master@{#433965}

Powered by Google App Engine
This is Rietveld 408576698