Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Side by Side Diff: third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.h

Issue 2509843004: Disable overlay scrollbars to hide them on non-Mac. (Closed)
Patch Set: Renamed to shouldDisableInvisibleScrollbars Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 void registerScrollbar(ScrollbarThemeClient&) override; 44 void registerScrollbar(ScrollbarThemeClient&) override;
45 void unregisterScrollbar(ScrollbarThemeClient&) override; 45 void unregisterScrollbar(ScrollbarThemeClient&) override;
46 void preferencesChanged(float initialButtonDelay, 46 void preferencesChanged(float initialButtonDelay,
47 float autoscrollButtonDelay, 47 float autoscrollButtonDelay,
48 NSScrollerStyle preferredScrollerStyle, 48 NSScrollerStyle preferredScrollerStyle,
49 bool redraw, 49 bool redraw,
50 WebScrollbarButtonsPlacement); 50 WebScrollbarButtonsPlacement);
51 51
52 bool supportsControlTints() const override { return true; } 52 bool supportsControlTints() const override { return true; }
53 53
54 // On Mac, the painting code itself animates the opacity so there's no need
55 // to disable in order to make the scrollbars invisible. In fact,
56 // disabling/enabling causes invalidations which can cause endless loops as
57 // Mac queues up scrollbar paint timers.
58 bool shouldDisableInvisibleScrollbars() const override { return false; }
59
54 double initialAutoscrollTimerDelay() override; 60 double initialAutoscrollTimerDelay() override;
55 double autoscrollTimerDelay() override; 61 double autoscrollTimerDelay() override;
56 62
57 void paintTickmarks(GraphicsContext&, 63 void paintTickmarks(GraphicsContext&,
58 const Scrollbar&, 64 const Scrollbar&,
59 const IntRect&) override; 65 const IntRect&) override;
60 66
61 bool shouldRepaintAllPartsOnInvalidation() const override { return false; } 67 bool shouldRepaintAllPartsOnInvalidation() const override { return false; }
62 ScrollbarPart invalidateOnThumbPositionChange( 68 ScrollbarPart invalidateOnThumbPositionChange(
63 const ScrollbarThemeClient&, 69 const ScrollbarThemeClient&,
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 110
105 int minimumThumbLength(const ScrollbarThemeClient&) override; 111 int minimumThumbLength(const ScrollbarThemeClient&) override;
106 112
107 int tickmarkBorderWidth() override { return 1; } 113 int tickmarkBorderWidth() override { return 1; }
108 114
109 RefPtr<Pattern> m_overhangPattern; 115 RefPtr<Pattern> m_overhangPattern;
110 }; 116 };
111 } 117 }
112 118
113 #endif // ScrollbarThemeMac_h 119 #endif // ScrollbarThemeMac_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698