third_party/WebKit/Source/core/fileapi/Blob.idl - Issue 2509833002: Make Blob#slice() contentType argument to be non nullable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fileapi/Blob.idl

Issue 2509833002: Make Blob#slice() contentType argument to be non nullable. (Closed)

Patch Set: Modified outdated tests Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fileapi/Blob.idl

diff --git a/third_party/WebKit/Source/core/fileapi/Blob.idl b/third_party/WebKit/Source/core/fileapi/Blob.idl

index d4799ada38f7d89bc79a31b8935114732fa6334a..e8748fe7a48d4cf2990ffea4141fad67fe28e442 100644

--- a/third_party/WebKit/Source/core/fileapi/Blob.idl

+++ b/third_party/WebKit/Source/core/fileapi/Blob.idl

@@ -43,6 +43,6 @@ typedef (ArrayBuffer or ArrayBufferView or Blob or USVString) BlobPart;

// TODO(jsbell): start and end arguments should be [Clamp]

// TODO(foolip): contentType should not be nullable.

jsbell 2016/11/17 19:52:24 remove this comment too!

lunalu1 2016/11/17 20:03:01 My bad.

- [RaisesException] Blob slice(optional long long start, optional long long end, optional DOMString? contentType);

+ [RaisesException] Blob slice(optional long long start, optional long long end, optional DOMString contentType);

[RaisesException, CallWith=ExecutionContext, RuntimeEnabled=FileAPIBlobClose] void close();

};