Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: headless/test/headless_browser_test.cc

Issue 2509813006: HeadlessWebContents:Observer to observe render process exit status (Closed)
Patch Set: Make it safe to call Shutdown() Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "headless/test/headless_browser_test.h" 5 #include "headless/test/headless_browser_test.h"
6 6
7 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/run_loop.h" 10 #include "base/run_loop.h"
11 #include "content/public/browser/browser_thread.h" 11 #include "content/public/browser/browser_thread.h"
12 #include "content/public/browser/render_process_host.h" 12 #include "content/public/browser/render_process_host.h"
13 #include "content/public/common/url_constants.h" 13 #include "content/public/common/url_constants.h"
14 #include "headless/lib/browser/headless_browser_impl.h" 14 #include "headless/lib/browser/headless_browser_impl.h"
15 #include "headless/lib/headless_content_main_delegate.h" 15 #include "headless/lib/headless_content_main_delegate.h"
16 #include "headless/public/devtools/domains/runtime.h" 16 #include "headless/public/devtools/domains/runtime.h"
17 #include "headless/public/headless_devtools_client.h" 17 #include "headless/public/headless_devtools_client.h"
18 #include "headless/public/headless_devtools_target.h" 18 #include "headless/public/headless_devtools_target.h"
19 #include "headless/public/headless_web_contents.h" 19 #include "headless/public/headless_web_contents.h"
20 #include "testing/gtest/include/gtest/gtest.h"
20 #include "ui/gfx/geometry/size.h" 21 #include "ui/gfx/geometry/size.h"
21 #include "url/gurl.h" 22 #include "url/gurl.h"
22 23
23 namespace headless { 24 namespace headless {
24 namespace { 25 namespace {
25 26
26 class SynchronousLoadObserver { 27 class SynchronousLoadObserver {
27 public: 28 public:
28 SynchronousLoadObserver(HeadlessBrowserTest* browser_test, 29 SynchronousLoadObserver(HeadlessBrowserTest* browser_test,
29 HeadlessWebContents* web_contents) 30 HeadlessWebContents* web_contents)
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 run_loop_->Run(); 178 run_loop_->Run();
178 run_loop_ = nullptr; 179 run_loop_ = nullptr;
179 } 180 }
180 181
181 void HeadlessBrowserTest::FinishAsynchronousTest() { 182 void HeadlessBrowserTest::FinishAsynchronousTest() {
182 run_loop_->Quit(); 183 run_loop_->Quit();
183 } 184 }
184 185
185 HeadlessAsyncDevTooledBrowserTest::HeadlessAsyncDevTooledBrowserTest() 186 HeadlessAsyncDevTooledBrowserTest::HeadlessAsyncDevTooledBrowserTest()
186 : web_contents_(nullptr), 187 : web_contents_(nullptr),
187 devtools_client_(HeadlessDevToolsClient::Create()) {} 188 devtools_client_(HeadlessDevToolsClient::Create()),
189 render_process_exited_(false) {}
188 190
189 HeadlessAsyncDevTooledBrowserTest::~HeadlessAsyncDevTooledBrowserTest() {} 191 HeadlessAsyncDevTooledBrowserTest::~HeadlessAsyncDevTooledBrowserTest() {}
190 192
191 void HeadlessAsyncDevTooledBrowserTest::DevToolsTargetReady() { 193 void HeadlessAsyncDevTooledBrowserTest::DevToolsTargetReady() {
192 EXPECT_TRUE(web_contents_->GetDevToolsTarget()); 194 EXPECT_TRUE(web_contents_->GetDevToolsTarget());
193 web_contents_->GetDevToolsTarget()->AttachClient(devtools_client_.get()); 195 web_contents_->GetDevToolsTarget()->AttachClient(devtools_client_.get());
194 RunDevTooledTest(); 196 RunDevTooledTest();
195 } 197 }
196 198
199 void HeadlessAsyncDevTooledBrowserTest::RenderProcessExited(
200 base::TerminationStatus status,
201 int exit_code) {
202 if (status == base::TERMINATION_STATUS_NORMAL_TERMINATION)
203 return;
204
205 FAIL() << "Abnormal renderer termination";
206 FinishAsynchronousTest();
207 render_process_exited_ = true;
208 }
209
197 void HeadlessAsyncDevTooledBrowserTest::RunTest() { 210 void HeadlessAsyncDevTooledBrowserTest::RunTest() {
198 browser_context_ = browser()->CreateBrowserContextBuilder().Build(); 211 browser_context_ = browser()->CreateBrowserContextBuilder().Build();
199 212
200 web_contents_ = browser_context_->CreateWebContentsBuilder().Build(); 213 web_contents_ = browser_context_->CreateWebContentsBuilder().Build();
201 web_contents_->AddObserver(this); 214 web_contents_->AddObserver(this);
202 215
203 RunAsynchronousTest(); 216 RunAsynchronousTest();
204 217
205 web_contents_->GetDevToolsTarget()->DetachClient(devtools_client_.get()); 218 if (!render_process_exited_)
219 web_contents_->GetDevToolsTarget()->DetachClient(devtools_client_.get());
206 web_contents_->RemoveObserver(this); 220 web_contents_->RemoveObserver(this);
207 web_contents_->Close(); 221 web_contents_->Close();
208 web_contents_ = nullptr; 222 web_contents_ = nullptr;
209 browser_context_->Close(); 223 browser_context_->Close();
210 browser_context_ = nullptr; 224 browser_context_ = nullptr;
211 } 225 }
212 226
213 } // namespace headless 227 } // namespace headless
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698