third_party/WebKit/Source/core/layout/ColumnBalancer.h - Issue 2509813004: Improve strut handling in initial column balancing pass.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ColumnBalancer.h

Issue 2509813004: Improve strut handling in initial column balancing pass. (Closed)

Patch Set: Rebaseline for column-rules-fixed-height. This test no longer triggers deep layout. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ColumnBalancer.h

diff --git a/third_party/WebKit/Source/core/layout/ColumnBalancer.h b/third_party/WebKit/Source/core/layout/ColumnBalancer.h

index 0593a6bed439a4e2200fa3c072a03f5914f819cb..18d2c862d49a4b5a420f97341164bc83a6d8e41a 100644

--- a/third_party/WebKit/Source/core/layout/ColumnBalancer.h

+++ b/third_party/WebKit/Source/core/layout/ColumnBalancer.h

@@ -225,6 +225,7 @@ class InitialColumnHeightFinder final : public ColumnBalancer {

Vector<LayoutUnit, 32> m_shortestStruts;

LayoutUnit m_tallestUnbreakableLogicalHeight;

+ LayoutUnit m_lastBreakSeen;

};

// If we have previously used InitialColumnHeightFinder to estimate an initial