Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2509813002: DOMParser: handle use from contexts without an "active document". (Closed)

Created:
4 years, 1 month ago by sof
Modified:
4 years, 1 month ago
Reviewers:
tkent, kouhei (in TOK)
CC:
chromium-reviews, blink-reviews, dominicc+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DOMParser: handle use from contexts without an "active document". Handle detached uses of parseFromString(), where there is no context document to inherit the security origin from. Relevant spec reference, https://w3c.github.io/DOM-Parsing/#dom-domparser-parsefromstring R= BUG=664399 Committed: https://crrev.com/65527a9ebb7eb8fd34c2f61b03ae7c85b7da5965 Cr-Commit-Position: refs/heads/master@{#432782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/dom/DOMParser-detached-no-crash.html View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/xml/DOMParser.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
sof
please take a look. The spec doesn't explicitly cover this case, https://w3c.github.io/DOM-Parsing/#dom-domparser-parsefromstring but API uses ...
4 years, 1 month ago (2016-11-16 20:11:32 UTC) #5
kouhei (in TOK)
lgtm Thanks for this fix!
4 years, 1 month ago (2016-11-17 00:16:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509813002/1
4 years, 1 month ago (2016-11-17 06:13:15 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 06:18:17 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 06:22:56 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65527a9ebb7eb8fd34c2f61b03ae7c85b7da5965
Cr-Commit-Position: refs/heads/master@{#432782}

Powered by Google App Engine
This is Rietveld 408576698