Don't reset scroll position of contents on every ScrollView layout.

Don't reset scroll position of contents on every ScrollView layout.

Also do a little cleanup in ash scrollview related code.

BUG=664930
Committed: https://crrev.com/210e0fa83113f83d29ac3c1203c2047e905601e9
Cr-Commit-Position: refs/heads/master@{#432749}

[Evan Stade, 2016-11-16 19:26:44]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2016-11-16 19:26:49]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 19:27:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-11-16 19:42:00]

p.s., I audited the task manager, the collected cookies view, and the bookmark
manager, all seem to continue functioning as expected.

[sky, 2016-11-16 20:12:57]

This looks fine. How about some test coverage?

https://codereview.chromium.org/2509783002/diff/1/ui/views/controls/scroll_vi...
File ui/views/controls/scroll_view.cc (right):

https://codereview.chromium.org/2509783002/diff/1/ui/views/controls/scroll_vi...
ui/views/controls/scroll_view.cc:316:
contents()->SetSize(gfx::Size(content_width, content_height));
It would be nice if we were consistent and used contents_ and not contents(). I
think it's this block that uses contents() rahter than contents_.

[commit-bot: I haz the power, 2016-11-16 20:38:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 20:38:27]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-11-17 01:13:41]

test added

[Evan Stade, 2016-11-17 01:14:01]

https://codereview.chromium.org/2509783002/diff/1/ui/views/controls/scroll_vi...
File ui/views/controls/scroll_view.cc (right):

https://codereview.chromium.org/2509783002/diff/1/ui/views/controls/scroll_vi...
ui/views/controls/scroll_view.cc:316:
contents()->SetSize(gfx::Size(content_width, content_height));
On 2016/11/16 20:12:57, sky wrote:
> It would be nice if we were consistent and used contents_ and not contents().
I
> think it's this block that uses contents() rahter than contents_.

(also done)

[Evan Stade, 2016-11-17 01:14:05]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 01:15:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-11-17 01:32:21]

Thanks! LGTM

[Evan Stade, 2016-11-17 01:34:55]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2016-11-17 01:35:01]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-11-17 01:36:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 02:04:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 02:04:55]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Evan Stade, 2016-11-17 02:56:48]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-11-17 02:56:49]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2509783002/#ps40001
(title: "make test work with scrolling by layer (I think) --- i.e. fix mac")

[commit-bot: I haz the power, 2016-11-17 02:58:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 04:59:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 05:01:34]

Description was changed from

==========
Don't reset scroll position of contents on every ScrollView layout.

Also do a little cleanup in ash scrollview related code.

BUG=664930
==========

to

==========
Don't reset scroll position of contents on every ScrollView layout.

Also do a little cleanup in ash scrollview related code.

BUG=664930

Committed: https://crrev.com/210e0fa83113f83d29ac3c1203c2047e905601e9
Cr-Commit-Position: refs/heads/master@{#432749}
==========

[commit-bot: I haz the power, 2016-11-17 05:01:35]

Patchset 3 (id:??) landed as
https://crrev.com/210e0fa83113f83d29ac3c1203c2047e905601e9
Cr-Commit-Position: refs/heads/master@{#432749}

[msramek, 2016-11-17 09:19:30]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2509243002/ by msramek@chromium.org.

The reason for reverting is: This change likely breaks
NativeWidgetMacTest.WindowModalSheet test on Mac.

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%2....