Issue 2509773003: Move ByteStringPool from document to indirect object holder.

Issue 2509773003: Move ByteStringPool from document to indirect object holder. (Closed)

Created:
4 years, 1 month ago by Tom Sepez

Modified:
4 years, 1 month ago

Reviewers:
dsinclair

CC:
pdfium-reviews_googlegroups.com

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Move ByteStringPool from document to indirect object holder. Since the indirect object holder is now in the object creation business, this will allow it to intern strings in a subsequent CL. Committed: https://pdfium.googlesource.com/pdfium/+/cc4d0a44f3025821f88f3ed1ee78dfdc416487c7

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -30 lines)			Patch
M	core/fpdfapi/parser/cfdf_document.h	View	1	3 chunks	+0 lines, -6 lines	0 comments	Download
M	core/fpdfapi/parser/cfdf_document.cpp	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	core/fpdfapi/parser/cpdf_document.h	View		3 chunks	+0 lines, -7 lines	0 comments	Download
M	core/fpdfapi/parser/cpdf_document.cpp	View		8 chunks	+13 lines, -12 lines	0 comments	Download
M	core/fpdfapi/parser/cpdf_indirect_object_holder.h	View		3 chunks	+7 lines, -0 lines	0 comments	Download
M	core/fpdfapi/parser/cpdf_indirect_object_holder.cpp	View		1 chunk	+6 lines, -2 lines	0 comments	Download

Dependent Patchsets:

Total messages: 13 (7 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509773003/20001

4 years, 1 month ago (2016-11-16 22:22:21 UTC) #11

commit-bot: I haz the power

4 years, 1 month ago (2016-11-16 22:45:47 UTC) #13

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/cc4d0a44f3025821f88f3ed1ee78dfdc4164...