Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2509753007: Fixes bug in handling window deletion originating from server (Closed)

Created:
4 years, 1 month ago by sky
Modified:
4 years, 1 month ago
Reviewers:
msw
CC:
chromium-reviews, rjkroege, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes bug in handling window deletion originating from server When the server tells the client a window was deleted the client would schedule deletion again with the server. This can cause problems as clients generally assume deletion succeeds and check otherwise. I'm also adding logging to window_tree in this patch. I think this is going to prove helpful for tracking down other similar issues and so I'm leading it in (DVLOG). BUG=659155 TEST=covered by test R=msw@chromium.org TBR=msw@chromium.org Committed: https://crrev.com/82255b3581f426db199117c3449bfe00bc38cb26 Cr-Commit-Position: refs/heads/master@{#433315}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -10 lines) Patch
M services/ui/ws/window_tree.cc View 2 chunks +13 lines, -2 lines 0 comments Download
M ui/aura/mus/in_flight_change.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/mus/window_mus.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/aura/mus/window_port_mus.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/aura/mus/window_port_mus.cc View 3 chunks +26 lines, -1 line 0 comments Download
M ui/aura/mus/window_tree_client.h View 2 chunks +6 lines, -1 line 0 comments Download
M ui/aura/mus/window_tree_client.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M ui/aura/mus/window_tree_client_unittest.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
I'm TBRing as you reviewed this in https://codereview.chromium.org/2500973002/ . I'm spinning this fix out of ...
4 years, 1 month ago (2016-11-18 20:43:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509753007/1
4 years, 1 month ago (2016-11-18 20:44:57 UTC) #3
msw
still lgtm
4 years, 1 month ago (2016-11-18 21:06:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 22:34:08 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 22:36:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82255b3581f426db199117c3449bfe00bc38cb26
Cr-Commit-Position: refs/heads/master@{#433315}

Powered by Google App Engine
This is Rietveld 408576698