Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2509753003: Initial TestExpectations vs. WPTServeExpectations cleanup (Closed)

Created:
4 years, 1 month ago by jsbell
Modified:
4 years, 1 month ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initial TestExpectations vs. WPTServeExpectations cleanup Now that --enable-wptserve is on by default we don't need an override expectations file. BUG=666111 R=tkent@chromium.org Committed: https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d Cr-Commit-Position: refs/heads/master@{#433041}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add dummy WPTServeExpectations #

Patch Set 3 : rebased #

Patch Set 4 : Rebased #

Patch Set 5 : Fail for sw/user-agent tests; rebaseline x-origin #

Patch Set 6 : Add expectation for cross-origin-objects.html #

Patch Set 7 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+790 lines, -1035 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 6 4 chunks +59 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/WPTServeExpectations View 1 1 chunk +1 line, -108 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/FileAPI/url/url_xmlhttprequest-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Document-createElement-namespace-expected.txt View 1 chunk +17 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/002-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-function-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-function-parent-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-function-src-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-src-about-blank-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/browsers/history/the-history-interface/009-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/browsers/history/the-history-interface/010-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/browsers/history/the-history-interface/history_pushstate_err-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/browsers/history/the-history-interface/history_replacestate_err-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/browsers/history/the-location-interface/security_location_0-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/browsers/offline/application-cache-api/api_status_idle-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/browsers/offline/application-cache-api/api_update-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt View 1 2 3 4 1 chunk +15 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/origin-of-data-document-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/browsers/the-window-object/Window-document-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/dom/elements/global-attributes/the-lang-attribute-003-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/dom/reflection-obsolete-expected.txt View 4 chunks +36 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/semantics/document-metadata/the-base-element/base_href_specified-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/semantics/document-metadata/the-link-element/document-without-browsing-context-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-control-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-br-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-source-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-text-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-source-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-text-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-iframe-element/same_origin_parentage-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-expected.txt View 1 chunk +640 lines, -640 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/form-submission-0/getactionurl-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/historical-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/scripting-1/the-script-element/script-onerror-insertion-point-2-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/scripting/processing-model-2/compile-error-cross-origin-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/scripting/processing-model-2/compile-error-in-setInterval-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/scripting/processing-model-2/compile-error-in-setTimeout-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/scripting/processing-model-2/runtime-error-cross-origin-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/scripting/processing-model-2/runtime-error-data-url-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/scripting/processing-model-2/runtime-error-in-setInterval-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/scripting/processing-model-2/runtime-error-in-setTimeout-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/system-state-and-capabilities/the-navigator-object/protocol-expected.txt View 1 chunk +0 lines, -74 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-header-visibility.https-expected.txt View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/postmessage-to-client.https-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/request-end-to-end.https-expected.txt View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/serviceworker-message-event-historical.https-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/webrtc/simplecall-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 32 (16 generated)
jsbell
tkent@ - I had this underway when I saw your note on crbug.com/666111 about picking ...
4 years, 1 month ago (2016-11-17 00:17:44 UTC) #1
tkent
On 2016/11/17 at 00:17:44, jsbell wrote: > tkent@ - I had this underway when I ...
4 years, 1 month ago (2016-11-17 00:24:25 UTC) #2
tkent
lgtm https://codereview.chromium.org/2509753003/diff/1/third_party/WebKit/LayoutTests/WPTServeExpectations File third_party/WebKit/LayoutTests/WPTServeExpectations (left): https://codereview.chromium.org/2509753003/diff/1/third_party/WebKit/LayoutTests/WPTServeExpectations#oldcode1 third_party/WebKit/LayoutTests/WPTServeExpectations:1: # Overriden expectations for imported tests when run ...
4 years, 1 month ago (2016-11-17 00:25:10 UTC) #3
jsbell
On 2016/11/17 00:25:10, tkent wrote: > lgtm > > https://codereview.chromium.org/2509753003/diff/1/third_party/WebKit/LayoutTests/WPTServeExpectations > File third_party/WebKit/LayoutTests/WPTServeExpectations (left): > ...
4 years, 1 month ago (2016-11-17 00:26:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509753003/20001
4 years, 1 month ago (2016-11-17 00:33:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/107291) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 1 month ago (2016-11-17 00:39:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509753003/40001
4 years, 1 month ago (2016-11-17 01:09:08 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/337291)
4 years, 1 month ago (2016-11-17 02:51:42 UTC) #15
jsbell
On 2016/11/17 02:51:42, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 1 month ago (2016-11-17 04:25:24 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509753003/100001
4 years, 1 month ago (2016-11-17 20:40:45 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/338028)
4 years, 1 month ago (2016-11-17 21:52:23 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509753003/100001
4 years, 1 month ago (2016-11-17 23:37:10 UTC) #23
commit-bot: I haz the power
Failed to apply the patch.
4 years, 1 month ago (2016-11-18 00:58:00 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509753003/120001
4 years, 1 month ago (2016-11-18 01:12:52 UTC) #28
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 1 month ago (2016-11-18 03:07:45 UTC) #30
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 03:10:57 UTC) #32
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/e831429bc4c93f3ff505ce56f1835babac6eef9d
Cr-Commit-Position: refs/heads/master@{#433041}

Powered by Google App Engine
This is Rietveld 408576698