Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2509753002: [profiler] Add extra CHECK to catch a crash in profiler. (Closed)

Created:
4 years, 1 month ago by alph
Modified:
4 years, 1 month ago
Reviewers:
lpy, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[profiler] Add extra CHECK to catch a crash in profiler. BUG=chromium:665398 Committed: https://crrev.com/b46bdcd5c35bc3f0eb831acb17b315d5024c1a22 Cr-Commit-Position: refs/heads/master@{#41084}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/profiler/profile-generator.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
alph
4 years, 1 month ago (2016-11-16 18:29:48 UTC) #2
Yang
On 2016/11/16 18:29:48, alph wrote: lgtm
4 years, 1 month ago (2016-11-17 07:35:36 UTC) #3
lpy
lgtm
4 years, 1 month ago (2016-11-17 07:56:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509753002/1
4 years, 1 month ago (2016-11-17 15:26:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 16:02:17 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:38:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b46bdcd5c35bc3f0eb831acb17b315d5024c1a22
Cr-Commit-Position: refs/heads/master@{#41084}

Powered by Google App Engine
This is Rietveld 408576698