third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp - Issue 2509713002: binding: Makes Dictionary throw an exception (constructor).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp

Issue 2509713002: binding: Makes Dictionary throw an exception (constructor). (Closed)

Patch Set: Addressed review comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/ArrayBufferOrArrayBufferViewOrDictionary.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp

index dd6e8fa3a7c8afac1865abb2358685860282f3c2..9150267b8b4650b70358646e67e0114666ac98d3 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp

@@ -106,7 +106,7 @@ void V8TestDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value

if (dictionaryMemberValue.IsEmpty() || dictionaryMemberValue->IsUndefined()) {

// Do nothing.

} else {

- Dictionary dictionaryMember = Dictionary(dictionaryMemberValue, isolate, exceptionState);

+ Dictionary dictionaryMember = Dictionary(isolate, dictionaryMemberValue, exceptionState);

if (exceptionState.hadException())

return;

if (!dictionaryMember.isObject()) {