third_party/WebKit/Source/bindings/scripts/v8_types.py - Issue 2509713002: binding: Makes Dictionary throw an exception (constructor).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_types.py

Issue 2509713002: binding: Makes Dictionary throw an exception (constructor). (Closed)

Patch Set: Addressed review comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_types.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_types.py b/third_party/WebKit/Source/bindings/scripts/v8_types.py

index dc6a037960bf121805d5694d662548f21e4b6fc2..a126e5474edd509793ff4726c9b276dfd1ba29d6 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_types.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_types.py

@@ -501,7 +501,7 @@ V8_VALUE_TO_CPP_VALUE = {

'long long': 'toInt64({isolate}, {arguments})',

'unsigned long long': 'toUInt64({isolate}, {arguments})',

# Interface types

- 'Dictionary': 'Dictionary({v8_value}, {isolate}, exceptionState)',

+ 'Dictionary': 'Dictionary({isolate}, {v8_value}, exceptionState)',

'EventTarget': 'toEventTarget({isolate}, {v8_value})',

'FlexibleArrayBufferView': 'toFlexibleArrayBufferView({isolate}, {v8_value}, {variable_name}, allocateFlexibleArrayBufferViewStorage({v8_value}))',

'NodeFilter': 'toNodeFilter({v8_value}, info.Holder(), ScriptState::current({isolate}))',