third_party/WebKit/Source/bindings/core/v8/DictionaryIterator.cpp - Issue 2509713002: binding: Makes Dictionary throw an exception (constructor).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/DictionaryIterator.cpp

Issue 2509713002: binding: Makes Dictionary throw an exception (constructor). (Closed)

Patch Set: Addressed review comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/DictionaryIterator.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/DictionaryIterator.cpp b/third_party/WebKit/Source/bindings/core/v8/DictionaryIterator.cpp

index a3c4898dd7a7cfeb2d2f867414afc917488e148a..e2548fc7d2688f87336d30a46da0522aa331aab5 100644

--- a/third_party/WebKit/Source/bindings/core/v8/DictionaryIterator.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/DictionaryIterator.cpp

@@ -91,7 +91,7 @@ bool DictionaryIterator::valueAsDictionary(Dictionary& result,

if (!v8Call(m_value, value) || !value->IsObject())

return false;

- result = Dictionary(value, m_isolate, exceptionState);

+ result = Dictionary(m_isolate, value, exceptionState);

return true;

}