binding: Makes Dictionary throw an exception (constructor).

third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp

Index: third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp
diff --git a/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp b/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp
index eb01435daf7821442ea2a04d27690bad57455d79..2006d072ba171a1a80d23f96c5a0fe416f84efa7 100644
--- a/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp
+++ b/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp
@@ -242,7 +242,8 @@ CryptoKey* convertCryptoResult<CryptoKey*>(const ScriptValue& value) {
 }
 template <>
 CryptoKeyPair convertCryptoResult<CryptoKeyPair>(const ScriptValue& value) {
-  Dictionary dictionary(value.isolate(), value.v8Value());
+  NonThrowableExceptionState exceptionState;

[bashi, 2016/11/18 15:03:55]

Should we add a comment ("Should rethrow the exception") here?

[Yuki, 2016/11/21 12:40:27]

Unlike TrackExceptionState, NonThrowableExceptionState checks throwing an
exception with NOTREACHED(), so it's okay.  If something throws an exception,
then the test fails.  That's it.

+  Dictionary dictionary(value.isolate(), value.v8Value(), exceptionState);
   v8::Local<v8::Value> privateKey, publicKey;
   EXPECT_TRUE(dictionary.get("publicKey", publicKey));
   EXPECT_TRUE(dictionary.get("privateKey", privateKey));