Cleaning data associated with the card upon deletion.

chrome/browser/resources/google_now/background.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @fileoverview The event page for Google Now for Chrome implementation.
  * The Google Now event page gets Google Now cards from the server and shows
  * them as Chrome notifications.
@@ skipping 281 matching lines @@
             }
           }
 
           // Delete notifications that didn't receive an update.
           for (var chromeNotificationId in notifications) {
                 console.log('parseAndShowNotificationCards-delete-check ' +
                         chromeNotificationId);
             if (!(chromeNotificationId in cards)) {
               console.log(
                   'showNotificationCards-delete ' + chromeNotificationId);
-              cardSet.clear(chromeNotificationId);
+              cardSet.clear(chromeNotificationId, false);
             }
           }
 
           // Create/update notifications and store their new properties.
           var newNotificationsData = {};
           for (var chromeNotificationId in cards) {
             var notificationData =
                 items.notificationsData[chromeNotificationId];
             var previousVersion = notifications[chromeNotificationId] &&
                                   notificationData &&
@@ skipping 493 matching lines @@
     chrome.storage.local.set({userRespondedToToast: true});
     return;
   }
 
   // At this point we are guaranteed that the notification is a now card.
   chrome.metricsPrivate.recordUserAction('GoogleNow.Dismissed');
 
   tasks.add(DISMISS_CARD_TASK_NAME, function() {
     dismissalAttempts.start();
 
-    // Deleting the notification in case it was re-added while this task was
-    // scheduled, waiting for execution.
-    cardSet.clear(chromeNotificationId);
-
     instrumented.storage.local.get(
         ['pendingDismissals', 'notificationsData'], function(items) {
       items.pendingDismissals = items.pendingDismissals || [];
       items.notificationsData = items.notificationsData || {};
 
+      // Deleting the notification in case it was re-added while this task was
+      // scheduled, waiting for execution; also cleaning notification's data
+      // from storage.
+      cardSet.clear(chromeNotificationId, true);
+
       var notificationData = items.notificationsData[chromeNotificationId];
 
       if (notificationData && notificationData.dismissals) {
         for (var i = 0; i < notificationData.dismissals.length; i++) {
           var dismissal = {
             chromeNotificationId: chromeNotificationId,
             time: Date.now(),
             dismissalData: notificationData.dismissals[i]
           };
           items.pendingDismissals.push(dismissal);
@@ skipping 318 matching lines @@
 
 instrumented.location.onLocationUpdate.addListener(function(position) {
   recordEvent(GoogleNowEvent.LOCATION_UPDATE);
   updateNotificationsCards(position);
 });
 
 instrumented.omnibox.onInputEntered.addListener(function(text) {
   localStorage['server_url'] = NOTIFICATION_CARDS_URL = text;
   initialize();
 });