Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: test/cctest/test-parsing.cc

Issue 2509683002: [counters] Use separate counters for background parsing (Closed)
Patch Set: using const arrays instead of two-level ternary syntax. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parsing/preparser.cc ('k') | tools/callstats.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index 75c7b5a97d9e1e516b0b83d2e1ebb25176dc717e..066b5dee0104f2525a3175f7e8aff7792cbe1b7d 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -175,8 +175,9 @@ TEST(ScanHTMLEndComments) {
&zone, CcTest::i_isolate()->heap()->HashSeed());
i::PendingCompilationErrorHandler pending_error_handler;
i::PreParser preparser(
- &zone, &scanner, &ast_value_factory, &pending_error_handler,
- CcTest::i_isolate()->counters()->runtime_call_stats(), stack_limit);
+ &zone, &scanner, stack_limit, &ast_value_factory,
+ &pending_error_handler,
+ CcTest::i_isolate()->counters()->runtime_call_stats());
i::PreParser::PreParseResult result = preparser.PreParseProgram();
CHECK_EQ(i::PreParser::kPreParseSuccess, result);
CHECK(!pending_error_handler.has_pending_error());
@@ -192,8 +193,9 @@ TEST(ScanHTMLEndComments) {
&zone, CcTest::i_isolate()->heap()->HashSeed());
i::PendingCompilationErrorHandler pending_error_handler;
i::PreParser preparser(
- &zone, &scanner, &ast_value_factory, &pending_error_handler,
- CcTest::i_isolate()->counters()->runtime_call_stats(), stack_limit);
+ &zone, &scanner, stack_limit, &ast_value_factory,
+ &pending_error_handler,
+ CcTest::i_isolate()->counters()->runtime_call_stats());
i::PreParser::PreParseResult result = preparser.PreParseProgram();
// Even in the case of a syntax error, kPreParseSuccess is returned.
CHECK_EQ(i::PreParser::kPreParseSuccess, result);
@@ -366,8 +368,9 @@ TEST(StandAlonePreParser) {
&zone, CcTest::i_isolate()->heap()->HashSeed());
i::PendingCompilationErrorHandler pending_error_handler;
i::PreParser preparser(
- &zone, &scanner, &ast_value_factory, &pending_error_handler,
- CcTest::i_isolate()->counters()->runtime_call_stats(), stack_limit);
+ &zone, &scanner, stack_limit, &ast_value_factory,
+ &pending_error_handler,
+ CcTest::i_isolate()->counters()->runtime_call_stats());
preparser.set_allow_natives(true);
i::PreParser::PreParseResult result = preparser.PreParseProgram();
CHECK_EQ(i::PreParser::kPreParseSuccess, result);
@@ -400,9 +403,9 @@ TEST(StandAlonePreParserNoNatives) {
i::AstValueFactory ast_value_factory(
&zone, CcTest::i_isolate()->heap()->HashSeed());
i::PendingCompilationErrorHandler pending_error_handler;
- i::PreParser preparser(
- &zone, &scanner, &ast_value_factory, &pending_error_handler,
- isolate->counters()->runtime_call_stats(), stack_limit);
+ i::PreParser preparser(&zone, &scanner, stack_limit, &ast_value_factory,
+ &pending_error_handler,
+ isolate->counters()->runtime_call_stats());
i::PreParser::PreParseResult result = preparser.PreParseProgram();
CHECK_EQ(i::PreParser::kPreParseSuccess, result);
CHECK(pending_error_handler.has_pending_error());
@@ -467,10 +470,10 @@ TEST(RegressChromium62639) {
i::AstValueFactory ast_value_factory(&zone,
CcTest::i_isolate()->heap()->HashSeed());
i::PendingCompilationErrorHandler pending_error_handler;
- i::PreParser preparser(&zone, &scanner, &ast_value_factory,
- &pending_error_handler,
- isolate->counters()->runtime_call_stats(),
- CcTest::i_isolate()->stack_guard()->real_climit());
+ i::PreParser preparser(&zone, &scanner,
+ CcTest::i_isolate()->stack_guard()->real_climit(),
+ &ast_value_factory, &pending_error_handler,
+ isolate->counters()->runtime_call_stats());
i::PreParser::PreParseResult result = preparser.PreParseProgram();
// Even in the case of a syntax error, kPreParseSuccess is returned.
CHECK_EQ(i::PreParser::kPreParseSuccess, result);
@@ -543,9 +546,9 @@ TEST(PreParseOverflow) {
i::AstValueFactory ast_value_factory(&zone,
CcTest::i_isolate()->heap()->HashSeed());
i::PendingCompilationErrorHandler pending_error_handler;
- i::PreParser preparser(
- &zone, &scanner, &ast_value_factory, &pending_error_handler,
- isolate->counters()->runtime_call_stats(), stack_limit);
+ i::PreParser preparser(&zone, &scanner, stack_limit, &ast_value_factory,
+ &pending_error_handler,
+ isolate->counters()->runtime_call_stats());
i::PreParser::PreParseResult result = preparser.PreParseProgram();
CHECK_EQ(i::PreParser::kPreParseStackOverflow, result);
}
@@ -1327,9 +1330,9 @@ void TestParserSyncWithFlags(i::Handle<i::String> source,
i::Zone zone(CcTest::i_isolate()->allocator(), ZONE_NAME);
i::AstValueFactory ast_value_factory(
&zone, CcTest::i_isolate()->heap()->HashSeed());
- i::PreParser preparser(
- &zone, &scanner, &ast_value_factory, &pending_error_handler,
- isolate->counters()->runtime_call_stats(), stack_limit);
+ i::PreParser preparser(&zone, &scanner, stack_limit, &ast_value_factory,
+ &pending_error_handler,
+ isolate->counters()->runtime_call_stats());
SetParserFlags(&preparser, flags);
scanner.Initialize(stream.get());
i::PreParser::PreParseResult result =
« no previous file with comments | « src/parsing/preparser.cc ('k') | tools/callstats.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698