[counters] Use separate counters for background parsing

[counters] Use separate counters for background parsing

BUG=

Committed: https://crrev.com/7e4e34bb8fc66aacd51629bb437ce67b67c86fbc
Cr-Commit-Position: refs/heads/master@{#41047}

[Camillo Bruni, 2016-11-16 14:26:25]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 14:26:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Camillo Bruni, 2016-11-16 14:29:04]

cbruni@chromium.org changed reviewers:
+ vogelheim@chromium.org

[Camillo Bruni, 2016-11-16 14:29:04]

PTAL

[commit-bot: I haz the power, 2016-11-16 14:30:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 14:30:37]

Dry run: Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[Camillo Bruni, 2016-11-16 14:40:37]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 14:40:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 15:06:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 15:06:02]

Dry run: This issue passed the CQ dry run.

[vogelheim, 2016-11-16 17:23:15]

lgtm

https://codereview.chromium.org/2509683002/diff/40001/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/2509683002/diff/40001/src/parsing/parser-base...
src/parsing/parser-base.h:3895: Impl::IsPreParser()
style: These two-level ternary operator expressions aren't super pretty to read.
Admittedly the alternatives aren't either, and the formatting makes it bearable,
so... please decide as you see fit.


---------------------------------
I see two alternatives:

- Either make a separate variable, and assign the proper value within two ifs.
  E.g., RuntimeCallCounter* counter; if (...) ... counter = &,...

- Or have a static const array that you can index with the two booleans you want
to decide on.
  E.g.:
   static const RuntimeCallCounter* const kCounters[2][2] = {
     {&RuntimeCallStats::ParseArrowFunctionLiteral, .... }, {...} };

  ... runtime_timer(...,
         kCounters[Impl::IsPreParser()][parsing_on_main_thread_]);

[Camillo Bruni, 2016-11-16 18:21:24]

https://codereview.chromium.org/2509683002/diff/40001/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/2509683002/diff/40001/src/parsing/parser-base...
src/parsing/parser-base.h:3895: Impl::IsPreParser()
On 2016/11/16 at 17:23:15, vogelheim wrote:
> style: These two-level ternary operator expressions aren't super pretty to
read. Admittedly the alternatives aren't either, and the formatting makes it
bearable, so... please decide as you see fit.
> 
> 
> ---------------------------------
> I see two alternatives:
> 
> - Either make a separate variable, and assign the proper value within two ifs.
>   E.g., RuntimeCallCounter* counter; if (...) ... counter = &,...
> 
> - Or have a static const array that you can index with the two booleans you
want to decide on.
>   E.g.:
>    static const RuntimeCallCounter* const kCounters[2][2] = {
>      {&RuntimeCallStats::ParseArrowFunctionLiteral, .... }, {...} };
> 
>   ... runtime_timer(...,
>          kCounters[Impl::IsPreParser()][parsing_on_main_thread_]);

You're right :)
Went with the helper array which makes it look a bit cleaner.

[Camillo Bruni, 2016-11-16 18:21:31]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 18:21:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Camillo Bruni, 2016-11-16 18:24:00]

The CQ bit was unchecked by cbruni@chromium.org

[Camillo Bruni, 2016-11-16 18:24:03]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-11-16 18:24:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2509683002/#ps60001
(title: "using const arrays instead of two-level ternary syntax.")

[commit-bot: I haz the power, 2016-11-16 18:24:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 18:51:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-17 22:36:52]

Description was changed from

==========
[counters] Use separate counters for background parsing

BUG=
==========

to

==========
[counters] Use separate counters for background parsing

BUG=

Committed: https://crrev.com/7e4e34bb8fc66aacd51629bb437ce67b67c86fbc
Cr-Commit-Position: refs/heads/master@{#41047}
==========

[commit-bot: I haz the power, 2016-11-17 22:36:53]

Patchset 4 (id:??) landed as
https://crrev.com/7e4e34bb8fc66aacd51629bb437ce67b67c86fbc
Cr-Commit-Position: refs/heads/master@{#41047}