Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2509643002: [Turbofan] Fix missing break on AstGraphBuilder VisitCall. (Closed)

Created:
4 years, 1 month ago by rmcilroy
Modified:
4 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Fix missing break on AstGraphBuilder VisitCall. Fixes a bug in ast-graph-builder added in r40965 BUG=chromium:665680 Committed: https://crrev.com/94e8417bb451ab83404f340550f4a25dfae627b3 Cr-Commit-Position: refs/heads/master@{#41034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/compiler/regress-665680.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
rmcilroy
Opps :/ - PTAL Michi, thanks.
4 years, 1 month ago (2016-11-16 12:51:20 UTC) #4
Michael Starzinger
LGTM.
4 years, 1 month ago (2016-11-16 13:11:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509643002/1
4 years, 1 month ago (2016-11-16 13:43:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 13:45:55 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/94e8417bb451ab83404f340550f4a25dfae627b3 Cr-Commit-Position: refs/heads/master@{#41034}
4 years, 1 month ago (2016-11-17 22:36:17 UTC) #12
Michael Hablich
https://chromium.googlesource.com/v8/v8/+/be9b820c4405e3feb1bcc60f5bf257c574da76c9 is in 5.6 but this CL is not. We should probably merge it to ...
4 years ago (2016-11-23 16:20:07 UTC) #13
rmcilroy
4 years ago (2016-11-23 20:57:56 UTC) #15
Message was sent while issue was closed.
On 2016/11/23 16:20:07, Hablich wrote:
>
https://chromium.googlesource.com/v8/v8/+/be9b820c4405e3feb1bcc60f5bf257c574d...
> is in 5.6 but this CL is not. We should probably merge it to 5.6, right?

Yes, please see merge request on
https://bugs.chromium.org/p/chromium/issues/detail?id=665680

Powered by Google App Engine
This is Rietveld 408576698