Fix KeyError caused when filtering gtests on multiple threads.

Fix KeyError caused when filtering gtests on multiple threads.

BUG=664337
Committed: https://crrev.com/c37f55cdd68e4715e9db17ede0a5ba7f4464ab8c
Cr-Commit-Position: refs/heads/master@{#433295}

[mikecase (-- gone --), 2016-11-17 00:07:39]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org

[mikecase (-- gone --), 2016-11-17 00:07:39]

https://hg.python.org/cpython/rev/fe12c34c39eb

Context: Here is the error. 

 File
"/b/swarm_slave/w/ir_49ot_/build/android/pylib/local/device/local_device_gtest_run.py",
line 341, in list_tests
    tests = self._test_instance.FilterTests(tests)
  File
"/b/swarm_slave/w/ir_49ot_/build/android/pylib/gtest/gtest_test_instance.py",
line 429, in FilterTests
    filtered_test_list, gtest_filter_string)
  File "/b/swarm_slave/w/ir_49ot_/build/util/lib/common/unittest_util.py", line
144, in FilterTestNames
    if (fnmatch.fnmatch(test, pattern)
  File "/usr/lib/python2.7/fnmatch.py", line 43, in fnmatch
    return fnmatchcase(name, pat)
  File "/usr/lib/python2.7/fnmatch.py", line 79, in fnmatchcase
    return _cache[pat].match(name) is not None
KeyError: 'MediaCanPlayTypeTest.CodecSupportTest_Mp4aVariants'

[jbudorick, 2016-11-17 00:16:03]

https://codereview.chromium.org/2509623003/diff/1/build/android/pylib/local/d...
File build/android/pylib/local/device/local_device_gtest_run.py (right):

https://codereview.chromium.org/2509623003/diff/1/build/android/pylib/local/d...
build/android/pylib/local/device/local_device_gtest_run.py:347: test_lists =
[self._test_instance.FilterTests(tests)
This change is ok, but it should also either:
 - make FilterTests threadsafe
 - add a comment in FilterTests's docstring explaining that it isn't threadsafe
and why.

[jbudorick, 2016-11-17 00:16:17]

On 2016/11/17 00:16:03, jbudorick wrote:
>
https://codereview.chromium.org/2509623003/diff/1/build/android/pylib/local/d...
> File build/android/pylib/local/device/local_device_gtest_run.py (right):
> 
>
https://codereview.chromium.org/2509623003/diff/1/build/android/pylib/local/d...
> build/android/pylib/local/device/local_device_gtest_run.py:347: test_lists =
> [self._test_instance.FilterTests(tests)
> This change is ok, but it should also either:
>  - make FilterTests threadsafe
>  - add a comment in FilterTests's docstring explaining that it isn't
threadsafe
> and why.

(my preference would be for the former)

[mikecase (-- gone --), 2016-11-18 02:26:55]

On 2016/11/17 at 00:16:17, jbudorick wrote:
> On 2016/11/17 00:16:03, jbudorick wrote:
> >
https://codereview.chromium.org/2509623003/diff/1/build/android/pylib/local/d...
> > File build/android/pylib/local/device/local_device_gtest_run.py (right):
> > 
> >
https://codereview.chromium.org/2509623003/diff/1/build/android/pylib/local/d...
> > build/android/pylib/local/device/local_device_gtest_run.py:347: test_lists =
> > [self._test_instance.FilterTests(tests)
> > This change is ok, but it should also either:
> >  - make FilterTests threadsafe
> >  - add a comment in FilterTests's docstring explaining that it isn't
threadsafe
> > and why.
> 
> (my preference would be for the former)

Done

[jbudorick, 2016-11-18 02:28:07]

lgtm

[mikecase (-- gone --), 2016-11-18 16:25:28]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2016-11-18 16:26:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 16:29:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 16:29:41]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mikecase (-- gone --), 2016-11-18 16:38:57]

On 2016/11/18 at 16:29:41, commit-bot wrote:
> Try jobs failed on following builders:
>   ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
>   ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
>   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

O_o

[mikecase (-- gone --), 2016-11-18 19:14:20]

The CQ bit was checked by mikecase@chromium.org

[mikecase (-- gone --), 2016-11-18 19:14:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2509623003/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-18 19:15:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 20:59:50]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-18 21:02:28]

Description was changed from

==========
Fix KeyError caused when filtering gtests on multiple threads.

BUG=664337
==========

to

==========
Fix KeyError caused when filtering gtests on multiple threads.

BUG=664337

Committed: https://crrev.com/c37f55cdd68e4715e9db17ede0a5ba7f4464ab8c
Cr-Commit-Position: refs/heads/master@{#433295}
==========

[commit-bot: I haz the power, 2016-11-18 21:02:30]

Patchset 5 (id:??) landed as
https://crrev.com/c37f55cdd68e4715e9db17ede0a5ba7f4464ab8c
Cr-Commit-Position: refs/heads/master@{#433295}