src/compiler/simplified-lowering.cc - Issue 2509623002: [turbofan] Sparse representation for state values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/simplified-lowering.cc

Issue 2509623002: [turbofan] Sparse representation for state values (Closed)

Patch Set: Remove the optimized_out input entirely, return nullptr when iterating Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/simplified-lowering.cc

diff --git a/src/compiler/simplified-lowering.cc b/src/compiler/simplified-lowering.cc

index c90d7437bfae4c5ec9a53c3d179a62e670a526ef..1d80e4ed2ab2ef655eb33a73d48ebe1fbb5e3f16 100644

--- a/src/compiler/simplified-lowering.cc

+++ b/src/compiler/simplified-lowering.cc

@@ -988,8 +988,9 @@ class RepresentationSelector {

machine_type.semantic() == MachineSemantic::kUint32);

(*types)[i] = machine_type;

}

- NodeProperties::ChangeOp(node,

- jsgraph_->common()->TypedStateValues(types));

+ uint32_t mask = OpParameter<uint32_t>(node);

+ NodeProperties::ChangeOp(

+ node, jsgraph_->common()->TypedStateValues(types, mask));

}

SetOutput(node, MachineRepresentation::kTagged);

}