src/compiler/bytecode-graph-builder.cc - Issue 2509623002: [turbofan] Sparse representation for state values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/bytecode-graph-builder.cc

Issue 2509623002: [turbofan] Sparse representation for state values (Closed)

Patch Set: Remove the optimized_out input entirely, return nullptr when iterating Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/bytecode-graph-builder.cc

diff --git a/src/compiler/bytecode-graph-builder.cc b/src/compiler/bytecode-graph-builder.cc

index 34b50df30811469ec9aef76092859436530afd6b..c9a7caca475a2a07a4bd6e3b0c79ee789db0da48 100644

--- a/src/compiler/bytecode-graph-builder.cc

+++ b/src/compiler/bytecode-graph-builder.cc

@@ -447,7 +447,7 @@ void BytecodeGraphBuilder::Environment::UpdateStateValues(Node** state_values,

int offset,

int count) {

if (StateValuesRequireUpdate(state_values, offset, count)) {

- const Operator* op = common()->StateValues(count);

+ const Operator* op = common()->StateValues(count, 0u);

(*state_values) = graph()->NewNode(op, count, &values()->at(offset));

}