Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: src/compiler/liveness-analyzer.cc

Issue 2509623002: [turbofan] Sparse representation for state values (Closed)
Patch Set: Add missing operator declarations Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/liveness-analyzer.cc
diff --git a/src/compiler/liveness-analyzer.cc b/src/compiler/liveness-analyzer.cc
index 0cf13332f4e8240de629eb7a13df71f908a60e21..b38708eb4b8ed78c699dac1ae0e9c04c1e874695 100644
--- a/src/compiler/liveness-analyzer.cc
+++ b/src/compiler/liveness-analyzer.cc
@@ -149,8 +149,8 @@ void NonLiveFrameStateSlotReplacer::ClearNonLiveFrameStateSlots(
static_cast<int>(StateValuesAccess(frame_state->InputAt(2)).size()), 1);
int index = liveness->length() - 1;
if (!liveness->Contains(index) && !permanently_live_.Contains(index)) {
- Node* new_value =
- state_values_cache()->GetNodeForValues(&replacement_node_, 1);
+ Node* new_value = state_values_cache()->GetNodeForValues(
+ &replacement_node_, 1, nullptr);
Jarin 2016/12/07 08:56:20 How about adding a default value (nullptr) for the
Leszek Swirski 2016/12/08 15:44:30 Ah, I had that originally but forgot to add it bac
frame_state->ReplaceInput(2, new_value);
}
}
@@ -176,7 +176,7 @@ Node* NonLiveFrameStateSlotReplacer::ClearNonLiveStateValues(
Node* result = state_values_cache()->GetNodeForValues(
inputs_buffer_.empty() ? nullptr : &(inputs_buffer_.front()),
- inputs_buffer_.size());
+ inputs_buffer_.size(), nullptr);
inputs_buffer_.clear();
return result;
}

Powered by Google App Engine
This is Rietveld 408576698